Skip to content

Commit c9488ae

Browse files
authored
fix: move --nolegacy_external_runfiles to version specific rc files (#1017)
1 parent 707b20e commit c9488ae

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

.aspect/bazelrc/bazel6.bazelrc

+8
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,11 @@ build --incompatible_remote_results_ignore_disk
4444
build --experimental_allow_tags_propagation
4545
fetch --experimental_allow_tags_propagation
4646
query --experimental_allow_tags_propagation
47+
48+
# Do not build runfiles symlink forests for external repositories under
49+
# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
50+
# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
51+
# default in the future. Note, some rules may fail under this flag, please file issues with the rule
52+
# author.
53+
# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
54+
build --nolegacy_external_runfiles

.aspect/bazelrc/bazel7.bazelrc

+8
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,11 @@ common --check_direct_dependencies=off
1313
# build.
1414
# Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
1515
build --reuse_sandbox_directories
16+
17+
# Do not build runfiles symlink forests for external repositories under
18+
# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
19+
# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
20+
# default in the future. Note, some rules may fail under this flag, please file issues with the rule
21+
# author.
22+
# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
23+
build --nolegacy_external_runfiles

.aspect/bazelrc/performance.bazelrc

-8
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@
55
# Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
66
build --experimental_reuse_sandbox_directories
77

8-
# Do not build runfiles symlink forests for external repositories under
9-
# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
10-
# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
11-
# default in the future. Note, some rules may fail under this flag, please file issues with the rule
12-
# author.
13-
# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
14-
build --nolegacy_external_runfiles
15-
168
# Avoid creating a runfiles tree for binaries or tests until it is needed.
179
# Docs: https://bazel.build/reference/command-line-reference#flag--build_runfile_links
1810
# See https://github.com/bazelbuild/bazel/issues/6627

0 commit comments

Comments
 (0)