Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Velero hook annotations configurable #658

Open
2 tasks done
a-vorobiev opened this issue Dec 2, 2024 · 0 comments
Open
2 tasks done

Make Velero hook annotations configurable #658

a-vorobiev opened this issue Dec 2, 2024 · 0 comments
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.

Comments

@a-vorobiev
Copy link

a-vorobiev commented Dec 2, 2024

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Currently Velero hook annotations use hardcoded path /vault/file for fsfreeze:

veleroAnnotations := map[string]string{
"pre.hook.backup.velero.io/container": "velero-fsfreeze",
"pre.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--freeze\", \"/vault/file/\"]",
"post.hook.backup.velero.io/container": "velero-fsfreeze",
"post.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--unfreeze\", \"/vault/file/\"]",
}

It is not possible to override these annotations with the vaultAnnotations, so there is no way to customize path for fsfreeze.

Proposed Solution

Make veleroAnnotations a part of custom resource with current value as a default.

Alternatives Considered

Get path from provided Vault configuration.

Additional Information

No response

@a-vorobiev a-vorobiev added the kind/enhancement Categorizes issue or PR as related to an improvement. label Dec 2, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Feb 2, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2025
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Feb 23, 2025
@bank-vaults bank-vaults deleted a comment from github-actions bot Feb 23, 2025
@bank-vaults bank-vaults deleted a comment from github-actions bot Feb 23, 2025
@csatib02 csatib02 reopened this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Development

No branches or pull requests

2 participants