Remove unnecessary cloning location variable

Author: warunalakshitha

ballerina/modules/parser/lexer.bal

@@ -55,7 +55,7 @@ public class Lexer {
             return {
                 kind: T_EOF,
                 value: "",
-                location: self.currentLocation.clone()
+                location: self.currentLocation
             };
         }
         int tokenTag = -1;
@@ -78,14 +78,14 @@ public class Lexer {
     }
 
     isolated function readSeparatorToken(string:Char char) returns Token? {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         _ = self.readNextChar();
         int kind = getTokenType(char);
         return getToken(char, kind, location);
     }
 
     isolated function readSpecialCharacterToken(string:Char char) returns Token {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         _ = self.readNextChar();
         int kind = getTokenType(char);
         return getToken(char, kind, location);
@@ -101,7 +101,7 @@ public class Lexer {
 
     isolated function readSingleLineStringLiteral() returns Token|SyntaxError {
         string word = "";
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         _ = self.readNextChar(); // Consume first double quote character
 
         string:Char? char = self.charReader.peek();
@@ -133,7 +133,7 @@ public class Lexer {
     }
 
     isolated function readBlockStringLiteral() returns Token|SyntaxError {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         string[] lines = [];
         string line = "";
         self.consumeIgnoreChars(3); // Consume first three double quote characters
@@ -234,7 +234,7 @@ public class Lexer {
     }
 
     isolated function readNumericLiteral(string:Char firstChar) returns Token|SyntaxError {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         string numeral = firstChar; // Passing first char to handle negative numbers.
         _ = self.readNextChar(); // Consume first char
         string:Char? character = self.charReader.peek();
@@ -306,7 +306,7 @@ public class Lexer {
     }
 
     isolated function readCommentToken() returns Token|SyntaxError {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         _ = self.readNextChar(); // Ignore first hash character
         string:Char? character = self.charReader.peek();
         string word = "#";
@@ -329,7 +329,7 @@ public class Lexer {
     }
 
     isolated function readEllipsisToken() returns Token|SyntaxError {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         string ellipsis = "";
         int i = 0;
         while i < 3 {
@@ -352,7 +352,7 @@ public class Lexer {
     }
 
     isolated function readIdentifierToken(string:Char firstChar) returns Token|SyntaxError {
-        Location location = self.currentLocation.clone();
+        Location location = self.currentLocation;
         _ = self.readNextChar();
         check validateFirstChar(firstChar, self.currentLocation);
         string word = firstChar;
@@ -367,7 +367,7 @@ public class Lexer {
             if tokenTag >= WHITE_SPACE_TAG && tokenTag <= SPECIAL_CHARACTER_TAG {
                 break;
             } else {
-                Location charLocation = self.currentLocation.clone();
+                Location charLocation = self.currentLocation;
                 _ = self.readNextChar();
                 check validateChar(char, charLocation);
                 word += char;

ballerina/modules/parser/parser.bal

@@ -61,7 +61,7 @@ public class Parser {
 
     isolated function parseOperationWithType(RootOperationType operationType) returns Error? {
         Token token = check self.readNextNonSeparatorToken();
-        Location location = token.location.clone();
+        Location location = token.location;
         token = check self.peekNextNonSeparatorToken();
         string operationName = check getOperationNameFromToken(self);
         token = check self.peekNextNonSeparatorToken();
@@ -76,7 +76,7 @@ public class Parser {
 
     isolated function parseFragment() returns Error? {
         Token token = check self.readNextNonSeparatorToken(); // fragment keyword already validated
-        Location location = token.location.clone();
+        Location location = token.location;
 
         token = check self.readNextNonSeparatorToken();
         string name = check getIdentifierTokenvalue(token);
@@ -124,10 +124,10 @@ public class Parser {
             if token.kind != T_DOLLAR {
                 return getExpectedCharError(token, DOLLAR);
             }
-            Location varDefinitionLocation = token.location.clone();
+            Location varDefinitionLocation = token.location;
             token = check self.readNextNonSeparatorToken();
             string name = check getIdentifierTokenvalue(token);
-            Location varLocation = token.location.clone();
+            Location varLocation = token.location;
             token = check self.readNextNonSeparatorToken();
             if token.kind != T_COLON {
                 return getExpectedCharError(token, COLON);
@@ -248,7 +248,7 @@ public class Parser {
         while token.kind != T_CLOSE_PARENTHESES {
             token = check self.readNextNonSeparatorToken();
             string name = check getIdentifierTokenvalue(token);
-            Location location = token.location.clone();
+            Location location = token.location;
             token = check self.readNextNonSeparatorToken();
             if token.kind != T_COLON {
                 return getExpectedCharError(token, COLON);
@@ -280,7 +280,7 @@ public class Parser {
         }
         while token.kind == T_AT {
             token = check self.readNextNonSeparatorToken(); //consume @
-            Location location = token.location.clone();
+            Location location = token.location;
             token = check self.readNextNonSeparatorToken();
             string name = check getIdentifierTokenvalue(token);
             token = check self.peekNextNonSeparatorToken();
@@ -301,7 +301,7 @@ public class Parser {
         while token.kind != T_CLOSE_PARENTHESES {
             token = check self.readNextNonSeparatorToken();
             string varName = check getIdentifierTokenvalue(token);
-            Location location = token.location.clone();
+            Location location = token.location;
             token = check self.readNextNonSeparatorToken();
             if token.kind != T_COLON {
                 return getExpectedCharError(token, COLON);
@@ -349,7 +349,7 @@ public class Parser {
             while token.kind != T_CLOSE_BRACE {
                 token = check self.readNextNonSeparatorToken();
                 string fieldName = check getIdentifierTokenvalue(token);
-                Location fieldLocation = token.location.clone();
+                Location fieldLocation = token.location;
                 if visitedFields.indexOf(fieldName) != () {
                     return getDuplicateFieldError(token);
                 }