Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove unnecessary cppcheck suppressions #7848

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 4, 2024

Description

Remove noValidConfiguration and preprocessorErrorDirective warnings.

Could be merged after #7786 is merged.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc requested review from HansRobo and kminoda July 4, 2024 09:56
@veqcc veqcc self-assigned this Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@HansRobo
Copy link
Member

HansRobo commented Jul 4, 2024

@HansRobo
Copy link
Member

HansRobo commented Jul 4, 2024

@veqcc maybe, we can delete uselessOverride too.

@veqcc
Copy link
Contributor Author

veqcc commented Jul 4, 2024

@HansRobo

maybe, we can delete uselessOverride too.

It is already deleted in main branch 👍

@veqcc
Copy link
Contributor Author

veqcc commented Jul 4, 2024

Now #7786 was merged!

Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Let's merge!!

@veqcc veqcc merged commit 7cbf2f5 into autowarefoundation:main Jul 4, 2024
33 checks passed
@veqcc veqcc deleted the chore/update_cppcheck_suppressions branch July 4, 2024 14:29
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…on#7848)

chore(ci): remove unnecessary suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…on#7848)

chore(ci): remove unnecessary suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
chore(ci): remove unnecessary suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…on#7848)

chore(ci): remove unnecessary suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants