-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pointcloud_preprocessor): fix preprocessorErrorDirective #7786
fix(pointcloud_preprocessor): fix preprocessorErrorDirective #7786
Conversation
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
For this one, I think only @yukkysaito can properly give an answer (since it is related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using the external file. Accepting this change would not be an issue, but reducing the differences might improve maintainability. However, since the upstream repository is publicly archived and the likelihood of future changes is very low, I think it's fine to accept this PR.
@yukkysaito Since May I add several commits before merging? See for detailed warnings: https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786
|
@veqcc Thank you. Since the upstream repository is publicly archived, we will need to maintain this file ourselves in the future. Considering this, I believe it would be better to fundamentally address the cppcheck issues rather than suppress them with inline cppcheck suppression. |
If there are a few additional commits, can I change it to draft until it is review ready? |
Of cource yes 👍 I will work on fixing blocking warnings later. |
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@vividf |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7786 +/- ##
==========================================
+ Coverage 28.67% 28.73% +0.05%
==========================================
Files 1587 1602 +15
Lines 116351 117295 +944
Branches 49687 49981 +294
==========================================
+ Hits 33365 33706 +341
- Misses 73930 74510 +580
- Partials 9056 9079 +23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@veqcc Sure, I will test it |
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes, and the pointcloud after this PR is the same as before.
LGTM!
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
…efoundation#7786) * fix(pointcloud_preprocessor): fix preprocessorErrorDirective Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * fix postfixOperator Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove unnecessary count() and contains() Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * restore bitness macros Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove operator= Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove addOrFree function Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: veqcc <ryuta.kambe@tier4.jp> Signed-off-by: palas21 <palas21@itu.edu.tr>
…efoundation#7786) * fix(pointcloud_preprocessor): fix preprocessorErrorDirective Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * fix postfixOperator Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove unnecessary count() and contains() Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * restore bitness macros Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove operator= Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove addOrFree function Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
* fix(pointcloud_preprocessor): fix preprocessorErrorDirective Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * fix postfixOperator Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove unnecessary count() and contains() Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * restore bitness macros Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove operator= Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove addOrFree function Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
…efoundation#7786) * fix(pointcloud_preprocessor): fix preprocessorErrorDirective Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * fix postfixOperator Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * remove unnecessary count() and contains() Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * restore bitness macros Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove operator= Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * remove addOrFree function Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * add cppcheck suppression Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Description
This is a fix based on cppcheck
preprocessorErrorDirective
warningThe
ROBIN_HOOD_PRIVATE_DEFINITION_BITNESS
macro is not used, right?Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
This
preprocessorErrorDirective
has prevented the cppcheck for analysingrobin_hood.h
file, so now it has a lot of cppcheck warnings, which is not acceptable in current CI workflow. See cppcheck-differential workflow for more detail.Interface changes
None.
Effects on system behavior
None.