fix(pointcloud_preprocessor): fix preprocessorErrorDirective

[veqcc]

Description

This is a fix based on cppcheck preprocessorErrorDirective warning

sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:132:2: error: #error Unsupported bitness [preprocessorErrorDirective]
#error Unsupported bitness
 ^

The ROBIN_HOOD_PRIVATE_DEFINITION_BITNESS macro is not used, right?

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

This preprocessorErrorDirective has prevented the cppcheck for analysing robin_hood.h file, so now it has a lot of cppcheck warnings, which is not acceptable in current CI workflow. See cppcheck-differential workflow for more detail.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[knzo25]

For this one, I think only @yukkysaito can properly give an answer (since it is related to the pickup_based_voxel_grid_downsample_filter)

[yukkysaito]

We are using the external file. Accepting this change would not be an issue, but reducing the differences might improve maintainability. However, since the upstream repository is publicly archived and the likelihood of future changes is very low, I think it's fine to accept this PR.

[veqcc]

@yukkysaito
Thank you for approving this PR!!

Since cppcheck-differential workflow is failing due to bugporone warings, we have to fix them before merging it.
The preprocessorErrorDirective error has been preventing cppcheck analysing this file properly so far.

May I add several commits before merging?
Or, do you prefer suppressing these warnings by inline cppcheck suppression?

See for detailed warnings: https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786

/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:425:3: warning: Member variable 'BulkPoolAllocator::mHead' is not assigned a value in 'BulkPoolAllocator::operator='. [operatorEqVarError]
  operator=(const BulkPoolAllocator & ROBIN_HOOD_UNUSED(o) /*unused*/) noexcept
  ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:425:3: warning: Member variable 'BulkPoolAllocator::mListForFree' is not assigned a value in 'BulkPoolAllocator::operator='. [operatorEqVarError]
  operator=(const BulkPoolAllocator & ROBIN_HOOD_UNUSED(o) /*unused*/) noexcept
  ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:586:8: warning: The struct 'NodeAllocator' defines member function with name 'addOrFree' also defined in its parent class 'BulkPoolAllocator'. [duplInheritedMember]
  void addOrFree(void * ptr, size_t ROBIN_HOOD_UNUSED(numBytes) /*unused*/) noexcept
       ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:4[7](https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786#step:11:8)2:8: note: Parent function 'BulkPoolAllocator::addOrFree'
  void addOrFree(void * ptr, const size_t numBytes) noexcept
       ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:5[8](https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786#step:11:9)6:8: note: Derived function 'NodeAllocator::addOrFree'
  void addOrFree(void * ptr, size_t ROBIN_HOOD_UNUSED(numBytes) /*unused*/) noexcept
       ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2033:[10](https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786#step:11:11): style: Variable 'kv' can be declared as pointer to const [constVariablePointer]
    auto kv = mKeyVals + findIdx(key);
         ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2045:10: style: Variable 'kv' can be declared as pointer to const [constVariablePointer]
    auto kv = mKeyVals + findIdx(key);
         ^
/home/runner/work/autoware.universe/autoware.universe/sensing/pointcloud_preprocessor/src/downsample_filter/robin_hood.h:[13](https://github.com/autowarefoundation/autoware.universe/actions/runs/9758833824/job/26934249776?pr=7786#step:11:14)76:7: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator]
      mKeyVals++;
      ^

[yukkysaito]

@veqcc Thank you. Since the upstream repository is publicly archived, we will need to maintain this file ourselves in the future. Considering this, I believe it would be better to fundamentally address the cppcheck issues rather than suppress them with inline cppcheck suppression.

[yukkysaito]

If there are a few additional commits, can I change it to draft until it is review ready?

[veqcc]

If there are a few additional commits, can I change it to draft until it is review ready?

Of cource yes 👍

I will work on fixing blocking warnings later.

[veqcc]

@vividf
HI, could you check the pointclouds are the same as before/after this PR?
I have fixed all the cppcheck warnigs.
Most of changes are deletions of existing codes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.73%. Comparing base (8df4b4c) to head (9edc719).
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7786      +/-   ##
==========================================
+ Coverage   28.67%   28.73%   +0.05%     
==========================================
  Files        1587     1602      +15     
  Lines      116351   117295     +944     
  Branches    49687    49981     +294     
==========================================
+ Hits        33365    33706     +341     
- Misses      73930    74510     +580     
- Partials     9056     9079      +23     

Flag	Coverage Δ		*Carryforward flag
differential	10.81% <100.00%> (?)
total	28.36% <ø> (-0.32%)	⬇️	Carriedforward from 68eee61

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vividf]

@veqcc Sure, I will test it

[vividf]

I tested the changes, and the pointcloud after this PR is the same as before.
LGTM!