test(euclidean_cluster): add unit tests #7735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yukkysaito
approved these changes
Jul 2, 2024
badai-nguyen
added
the
run:build-and-test-differential
YoshiRi
requested changes
Jul 2, 2024
|
|
||
| // Test case 3: Test case when the input pointcloud has two clusters with points number greater to | ||
| // max_cluster_size | ||
| TEST(VoxelGridBasedEuclideanClusterTest, testcase3) |
There was a problem hiding this comment.
Test failed.
1: /home/yoshiri/autoware/src/universe/autoware.universe/perception/euclidean_cluster/test/test_voxel_grid_based_euclidean_cluster.cpp:165: Failure
1: Expected equality of these values:
1: output.feature_objects.size()
1: Which is: 1
1: 0
1: [ FAILED ] VoxelGridBasedEuclideanClusterTest.testcase3 (0 ms)
1: [----------] 3 tests from VoxelGridBasedEuclideanClusterTest (3 ms total)
perception/euclidean_cluster/test/test_voxel_grid_based_euclidean_cluster.cpp
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7735 +/- ##
==========================================
- Coverage 28.75% 28.37% -0.39%
==========================================
Files 1594 1619 +25
Lines 116892 115824 -1068
Branches 50050 49220 -830
==========================================
- Hits 33616 32865 -751
+ Misses 74178 73956 -222
+ Partials 9098 9003 -95
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
YoshiRi
changed the title
|
@YoshiRi I updated branch and all tests were passed. Could you review this again? |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Ariiees
pushed a commit
to Ariiees/autoware.universe
that referenced
this pull request
Jul 22, 2024
* chore(euclidean_cluster): add unit tests Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: pre-commit Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: namespace update Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clusterfunction ofVoxelGridBasedEuclideanClusterRelated links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.