feat(planning_factor): support new cruise planner's factor #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
github-actions
bot
added
the
component:system
KYabuuchi
changed the title
KYabuuchi
added
the
run:build-and-test-differential
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10229 +/- ##
==========================================
+ Coverage 26.40% 26.45% +0.05%
==========================================
Files 1389 1392 +3
Lines 107705 107744 +39
Branches 41496 41496
==========================================
+ Hits 28440 28507 +67
+ Misses 76429 76395 -34
- Partials 2836 2842 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KYabuuchi
requested review from
isamu-takagi,
mitsudome-r and
yukkysaito
as code owners
|
@isamu-takagi @mitsudome-r @yukkysaito Could you review this PR as code owner? 🙏 |
isamu-takagi
approved these changes
Mar 10, 2025
|
Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a conversion for a new planning_factor.
background
Recently,
obstacle_cruise_plannerandobstacle_stop_plannercan be launched as modules ofmotion_velocity_plannerinstead of as standalone nodes. (The traditional nodes can still be launched.)⛓️ reference: Split obstacle_cruise_planner to obstacle stop, slow_down, and cruise, and port them to motion_velocity_planer
With this change, a new planning_factor for obstacle_cruise/stop/slowdown_planner has been added.
Related links
Parent Issue:
How was this PR tested?
I launched planning_simulator.launch.xml and checked the subscriber of
/adapi/node/planning.The new planning_factors can be found by
ros2 node info /planning/scenario_planning/lane_driving/motion_planning/motion_velocity_planner.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior