Skip to content

Commit fdfe33c

Browse files
committed
add comments
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1 parent cf552f6 commit fdfe33c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

control/autoware_mpc_lateral_controller/src/mpc.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@ VectorXd MPC::calcSteerRateLimitOnTrajectory(
765765
return reference.back();
766766
};
767767

768-
// when the vehicle is stopped, no steering rate limit.
768+
// When the vehicle is stopped, a large steer rate limit is used for the dry steering.
769769
constexpr double steer_rate_lim = 100.0;
770770
const bool is_vehicle_stopped = std::fabs(current_velocity) < 0.01;
771771
if (is_vehicle_stopped) {

control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,9 @@ void PidLongitudinalController::updateControlState(const ControlData & control_d
721721
const bool current_keep_stopped_condition = std::fabs(current_vel) < vel_epsilon &&
722722
m_enable_keep_stopped_until_steer_convergence &&
723723
!lateral_sync_data_.is_steer_converged;
724+
// NOTE: Dry steering is considered unnecessary when the steering is converged twice in a
725+
// row. This is because lateral_sync_data_.is_steer_converged is not the current but
726+
// the previous value due to the order controllers' run and sync functions.
724727
const bool keep_stopped_condition =
725728
!m_prev_keep_stopped_condition ||
726729
(current_keep_stopped_condition || *m_prev_keep_stopped_condition);

0 commit comments

Comments
 (0)