Skip to content

Commit f80acd2

Browse files
committed
chore: solve conflicts
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
2 parents 6351aeb + deef7c4 commit f80acd2

File tree

218 files changed

+2854
-2193
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

218 files changed

+2854
-2193
lines changed

.cppcheck_suppressions

-6
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,9 @@ knownConditionTrueFalse
1313
missingInclude
1414
missingIncludeSystem
1515
noConstructor
16-
noExplicitConstructor
17-
noValidConfiguration
1816
passedByValue
19-
preprocessorErrorDirective
2017
redundantInitialization
21-
shadowFunction
2218
shadowVariable
23-
syntaxError
2419
// cspell: ignore uninit
2520
uninitMemberVar
2621
unknownMacro
@@ -30,6 +25,5 @@ unusedFunction
3025
unusedStructMember
3126
useInitializationList
3227
useStlAlgorithm
33-
uselessOverride
3428
variableScope
3529
virtualCallInConstructor

.github/CODEOWNERS

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ common/autoware_motion_utils/** fumiya.watanabe@tier4.jp kosuke.takeuchi@tier4.j
66
common/autoware_overlay_rviz_plugin/autoware_mission_details_overlay_rviz_plugin/** ahmed.ebrahim@leodrive.ai
77
common/autoware_overlay_rviz_plugin/autoware_overlay_rviz_plugin/** khalil@leodrive.ai
88
common/autoware_perception_rviz_plugin/** opensource@apex.ai satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taiki.tanaka@tier4.jp takeshi.miura@tier4.jp yoshi.ri@tier4.jp
9-
common/autoware_point_types/** taichi.higashide@tier4.jp
9+
common/autoware_point_types/** david.wong@tier4.jp max.schmeller@tier4.jp
1010
common/autoware_test_utils/** kyoichi.sugahara@tier4.jp mamoru.sobue@tier4.jp takamasa.horibe@tier4.jp zulfaqar.azmi@tier4.jp
1111
common/autoware_testing/** adam.dabrowski@robotec.ai satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
1212
common/autoware_universe_utils/** mamoru.sobue@tier4.jp takamasa.horibe@tier4.jp takayuki.murooka@tier4.jp
@@ -115,9 +115,9 @@ perception/elevation_map_loader/** kosuke.takeuchi@tier4.jp shintaro.tomie@tier4
115115
perception/euclidean_cluster/** dai.nguyen@tier4.jp yukihiro.saito@tier4.jp
116116
perception/ground_segmentation/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp shunsuke.miura@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
117117
perception/image_projection_based_fusion/** dai.nguyen@tier4.jp koji.minoda@tier4.jp kotaro.uetake@tier4.jp shunsuke.miura@tier4.jp tao.zhong@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
118-
perception/lidar_apollo_instance_segmentation/** yukihiro.saito@tier4.jp
119-
perception/lidar_apollo_segmentation_tvm/** ambroise.vincent@arm.com xinyu.wang@tier4.jp
120-
perception/lidar_apollo_segmentation_tvm_nodes/** ambroise.vincent@arm.com xinyu.wang@tier4.jp
118+
perception/lidar_apollo_instance_segmentation/** yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
119+
perception/lidar_apollo_segmentation_tvm/** ambroise.vincent@arm.com yoshi.ri@tier4.jp
120+
perception/lidar_apollo_segmentation_tvm_nodes/** ambroise.vincent@arm.com yoshi.ri@tier4.jp
121121
perception/lidar_centerpoint/** kenzo.lobos@tier4.jp koji.minoda@tier4.jp
122122
perception/lidar_transfusion/** amadeusz.szymko.2@tier4.jp kenzo.lobos@tier4.jp satoshi.tanaka@tier4.jp
123123
perception/multi_object_tracker/** taekjin.lee@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
@@ -204,7 +204,7 @@ sensing/gnss_poser/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minod
204204
sensing/image_diagnostics/** dai.nguyen@tier4.jp yoshi.ri@tier4.jp
205205
sensing/image_transport_decompressor/** kenzo.lobos@tier4.jp yukihiro.saito@tier4.jp
206206
sensing/imu_corrector/** koji.minoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
207-
sensing/livox/livox_tag_filter/** kenzo.lobos@tier4.jp ryohsuke.mitsudome@tier4.jp
207+
sensing/livox/autoware_livox_tag_filter/** kenzo.lobos@tier4.jp ryohsuke.mitsudome@tier4.jp
208208
sensing/pointcloud_preprocessor/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp david.wong@tier4.jp kenzo.lobos@tier4.jp kyoichi.sugahara@tier4.jp melike@leodrive.ai shunsuke.miura@tier4.jp yihsiang.fang@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
209209
sensing/radar_scan_to_pointcloud2/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taekjin.lee@tier4.jp yoshi.ri@tier4.jp
210210
sensing/radar_static_pointcloud_filter/** satoshi.tanaka@tier4.jp shunsuke.miura@tier4.jp taekjin.lee@tier4.jp yoshi.ri@tier4.jp

.github/workflows/cppcheck-differential.yaml

+18-6
Original file line numberDiff line numberDiff line change
@@ -53,31 +53,43 @@ jobs:
5353
done
5454
echo "full-paths=$paths" >> $GITHUB_OUTPUT
5555
56+
- name: Filter packages with no cpp/hpp files
57+
id: filter-paths-no-cpp-files
58+
run: |
59+
filtered_paths=""
60+
for dir in ${{ steps.get-full-paths.outputs.full-paths }}; do
61+
if [ -d "$dir" ] && find "$dir" -name "*.cpp" -o -name "*.hpp" | grep -q .; then
62+
filtered_paths="$filtered_paths $dir"
63+
fi
64+
done
65+
echo "filtered-full-paths=$filtered_paths" >> $GITHUB_OUTPUT
66+
5667
# cspell: ignore suppr
5768
- name: Run Cppcheck on modified packages
58-
if: ${{ steps.get-modified-packages.outputs.modified-packages != '' }}
69+
if: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths != '' }}
5970
continue-on-error: true
6071
id: cppcheck
6172
run: |
62-
echo "Running Cppcheck on modified packages: ${{ steps.get-modified-packages.outputs.modified-packages }}"
63-
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --suppressions-list=.cppcheck_suppressions --inline-suppr ${{ steps.get-full-paths.outputs.full-paths }} 2> cppcheck-report.txt
73+
echo "Running Cppcheck on modified packages: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths }}"
74+
cppcheck --enable=all --inconclusive --check-level=exhaustive --error-exitcode=1 --suppressions-list=.cppcheck_suppressions --inline-suppr ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths }} 2> cppcheck-report.txt
6475
shell: bash
6576

6677
- name: Setup Problem Matchers for cppcheck
78+
if: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths != '' }}
6779
run: echo "::add-matcher::.github/cppcheck-problem-matcher.json"
6880

6981
- name: Show cppcheck-report result
70-
if: ${{ steps.get-modified-packages.outputs.modified-packages != '' }}
82+
if: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths != '' }}
7183
run: |
7284
cat cppcheck-report.txt
7385
7486
- name: Upload Cppcheck report
75-
if: ${{ steps.get-modified-packages.outputs.modified-packages != '' }}
87+
if: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths != '' }}
7688
uses: actions/upload-artifact@v2
7789
with:
7890
name: cppcheck-report
7991
path: cppcheck-report.txt
8092

8193
- name: Fail the job if Cppcheck failed
82-
if: ${{ steps.get-modified-packages.outputs.modified-packages != '' && steps.cppcheck.outcome == 'failure' }}
94+
if: ${{ steps.filter-paths-no-cpp-files.outputs.filtered-full-paths != '' && steps.cppcheck.outcome == 'failure' }}
8395
run: exit 1

common/autoware_ad_api_specs/include/autoware_ad_api_specs/vehicle.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ struct VehicleKinematics
3232
using Message = autoware_adapi_v1_msgs::msg::VehicleKinematics;
3333
static constexpr char name[] = "/api/vehicle/kinematics";
3434
static constexpr size_t depth = 1;
35-
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE;
35+
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_BEST_EFFORT;
3636
static constexpr auto durability = RMW_QOS_POLICY_DURABILITY_VOLATILE;
3737
};
3838

common/fake_test_node/test/test_fake_test_node.cpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,7 @@ TEST_F(FakeNodeFixture, Test)
9696
}
9797

9898
INSTANTIATE_TEST_SUITE_P(
99-
FakeNodeFixtureTests, FakeNodeFixtureParametrized,
100-
// cppcheck-suppress syntaxError // cppcheck doesn't like the trailing comma.
101-
::testing::Values(-5, 0, 42));
99+
FakeNodeFixtureTests, FakeNodeFixtureParametrized, ::testing::Values(-5, 0, 42));
102100

103101
/// @test Test that we can use a parametrized test.
104102
TEST_P(FakeNodeFixtureParametrized, Test)

common/osqp_interface/test/test_osqp_interface.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ namespace
3737
// y = [-2.9, 0.0, 0.2, 0.0]`
3838
// obj = 1.88
3939

40-
// cppcheck-suppress syntaxError
4140
TEST(TestOsqpInterface, BasicQp)
4241
{
4342
using autoware::common::osqp::calCSCMatrix;

common/qp_interface/test/test_osqp_interface.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ namespace
3737
// y = [-2.9, 0.0, 0.2, 0.0]`
3838
// obj = 1.88
3939

40-
// cppcheck-suppress syntaxError
4140
TEST(TestOsqpInterface, BasicQp)
4241
{
4342
using qp::calCSCMatrix;

common/qp_interface/test/test_proxqp_interface.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ namespace
3838
// y = [-2.9, 0.0, 0.2, 0.0]`
3939
// obj = 1.88
4040

41-
// cppcheck-suppress syntaxError
4241
TEST(TestProxqpInterface, BasicQp)
4342
{
4443
auto check_result = [](const auto & solution) {

evaluator/autoware_planning_evaluator/include/autoware/planning_evaluator/planning_evaluator_node.hpp

+33-13
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ class PlanningEvaluatorNode : public rclcpp::Node
7070
* @brief callback on receiving a trajectory
7171
* @param [in] traj_msg received trajectory message
7272
*/
73-
void onTrajectory(const Trajectory::ConstSharedPtr traj_msg);
73+
void onTrajectory(
74+
const Trajectory::ConstSharedPtr traj_msg, const Odometry::ConstSharedPtr ego_state_ptr);
7475

7576
/**
7677
* @brief callback on receiving a reference trajectory
@@ -88,7 +89,9 @@ class PlanningEvaluatorNode : public rclcpp::Node
8889
* @brief callback on receiving a modified goal
8990
* @param [in] modified_goal_msg received modified goal message
9091
*/
91-
void onModifiedGoal(const PoseWithUuidStamped::ConstSharedPtr modified_goal_msg);
92+
void onModifiedGoal(
93+
const PoseWithUuidStamped::ConstSharedPtr modified_goal_msg,
94+
const Odometry::ConstSharedPtr ego_state_ptr);
9295

9396
/**
9497
* @brief publish the given metric statistic
@@ -99,26 +102,43 @@ class PlanningEvaluatorNode : public rclcpp::Node
99102
/**
100103
* @brief publish current ego lane info
101104
*/
102-
DiagnosticStatus generateLaneletDiagnosticStatus();
105+
DiagnosticStatus generateLaneletDiagnosticStatus(const Odometry::ConstSharedPtr ego_state_ptr);
103106

104107
/**
105108
* @brief publish current ego kinematic state
106109
*/
107110
DiagnosticStatus generateKinematicStateDiagnosticStatus(
108-
const AccelWithCovarianceStamped & accel_stamped);
111+
const AccelWithCovarianceStamped & accel_stamped, const Odometry::ConstSharedPtr ego_state_ptr);
109112

110113
private:
111114
static bool isFinite(const TrajectoryPoint & p);
112-
void publishModifiedGoalDeviationMetrics();
113-
// update Route Handler
115+
116+
/**
117+
* @brief update route handler data
118+
*/
114119
void getRouteData();
115120

121+
/**
122+
* @brief fetch data and publish diagnostics
123+
*/
124+
void onTimer();
125+
126+
/**
127+
* @brief fetch topic data
128+
*/
129+
void fetchData();
130+
116131
// ROS
117-
rclcpp::Subscription<Trajectory>::SharedPtr traj_sub_;
118-
rclcpp::Subscription<Trajectory>::SharedPtr ref_sub_;
119-
rclcpp::Subscription<PredictedObjects>::SharedPtr objects_sub_;
120-
rclcpp::Subscription<PoseWithUuidStamped>::SharedPtr modified_goal_sub_;
121-
rclcpp::Subscription<Odometry>::SharedPtr odom_sub_;
132+
autoware::universe_utils::InterProcessPollingSubscriber<Trajectory> traj_sub_{
133+
this, "~/input/trajectory"};
134+
autoware::universe_utils::InterProcessPollingSubscriber<Trajectory> ref_sub_{
135+
this, "~/input/reference_trajectory"};
136+
autoware::universe_utils::InterProcessPollingSubscriber<PredictedObjects> objects_sub_{
137+
this, "~/input/objects"};
138+
autoware::universe_utils::InterProcessPollingSubscriber<PoseWithUuidStamped> modified_goal_sub_{
139+
this, "~/input/modified_goal"};
140+
autoware::universe_utils::InterProcessPollingSubscriber<Odometry> odometry_sub_{
141+
this, "~/input/odometry"};
122142
autoware::universe_utils::InterProcessPollingSubscriber<LaneletRoute> route_subscriber_{
123143
this, "~/input/route", rclcpp::QoS{1}.transient_local()};
124144
autoware::universe_utils::InterProcessPollingSubscriber<LaneletMapBin> vector_map_subscriber_{
@@ -131,6 +151,7 @@ class PlanningEvaluatorNode : public rclcpp::Node
131151
std::unique_ptr<tf2_ros::Buffer> tf_buffer_;
132152
autoware::route_handler::RouteHandler route_handler_;
133153

154+
DiagnosticArray metrics_msg_;
134155
// Parameters
135156
std::string output_file_str_;
136157
std::string ego_frame_str_;
@@ -142,8 +163,7 @@ class PlanningEvaluatorNode : public rclcpp::Node
142163
std::deque<rclcpp::Time> stamps_;
143164
std::array<std::deque<Stat<double>>, static_cast<size_t>(Metric::SIZE)> metric_stats_;
144165

145-
Odometry::ConstSharedPtr ego_state_ptr_;
146-
PoseWithUuidStamped::ConstSharedPtr modified_goal_ptr_;
166+
rclcpp::TimerBase::SharedPtr timer_;
147167
std::optional<AccelWithCovarianceStamped> prev_acc_stamped_{std::nullopt};
148168
};
149169
} // namespace planning_diagnostics

0 commit comments

Comments
 (0)