Skip to content

Commit b648a00

Browse files
f0reachARRHansRobo
andauthored
fix: replace deprecated header in Jazzy (#7603)
* Use cv_bridge.hpp if available Signed-off-by: f0reachARR <f0reach@f0reach.me> * Fix image_geometry deprecated header Signed-off-by: f0reachARR <f0reach@f0reach.me> * Add comment for __has_include Signed-off-by: f0reachARR <f0reach@f0reach.me> --------- Signed-off-by: f0reachARR <f0reach@f0reach.me> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
1 parent 2a3eaee commit b648a00

File tree

10 files changed

+53
-10
lines changed

10 files changed

+53
-10
lines changed

localization/autoware_landmark_based_localizer/autoware_ar_tag_based_localizer/src/ar_tag_based_localizer.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,11 @@
5151
#include <opencv4/opencv2/calib3d.hpp>
5252
#include <opencv4/opencv2/core/quaternion.hpp>
5353

54-
#include <cv_bridge/cv_bridge.h>
54+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
55+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
56+
#else
57+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
58+
#endif
5559
#include <tf2/LinearMath/Transform.h>
5660

5761
#include <algorithm>

localization/yabloc/yabloc_common/src/cv_decompress.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
#include <opencv4/opencv2/imgcodecs.hpp>
1818
#include <opencv4/opencv2/imgproc.hpp>
1919

20-
#include <cv_bridge/cv_bridge.h>
20+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
21+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
22+
#else
23+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
24+
#endif
2125

2226
#include <iostream>
2327

localization/yabloc/yabloc_common/src/pub_sub.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@
1414

1515
#include "yabloc_common/pub_sub.hpp"
1616

17-
#include <cv_bridge/cv_bridge.h>
17+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
18+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
19+
#else
20+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
21+
#endif
1822
#include <pcl_conversions/pcl_conversions.h>
1923

2024
namespace yabloc::common

localization/yabloc/yabloc_image_processing/src/line_segments_overlay/line_segments_overlay_core.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@
1818
#include <yabloc_common/cv_decompress.hpp>
1919
#include <yabloc_common/pub_sub.hpp>
2020

21-
#include <cv_bridge/cv_bridge.h>
21+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
22+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
23+
#else
24+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
25+
#endif
2226
#include <pcl_conversions/pcl_conversions.h>
2327

2428
namespace yabloc::line_segments_overlay

localization/yabloc/yabloc_image_processing/src/undistort/undistort_node.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@
2424
#include <sensor_msgs/msg/compressed_image.hpp>
2525
#include <sensor_msgs/msg/image.hpp>
2626

27-
#include <cv_bridge/cv_bridge.h>
27+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
28+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
29+
#else
30+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
31+
#endif
2832

2933
#include <optional>
3034

localization/yabloc/yabloc_pose_initializer/src/camera/camera_pose_initializer_core.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@
2020
#include <opencv2/highgui.hpp>
2121
#include <opencv2/imgproc.hpp>
2222

23-
#include <cv_bridge/cv_bridge.h>
23+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
24+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
25+
#else
26+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
27+
#endif
2428

2529
#include <filesystem>
2630

perception/traffic_light_map_based_detector/include/traffic_light_map_based_detector/node.hpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,12 @@
2525
#include <tier4_perception_msgs/msg/traffic_light_roi_array.hpp>
2626
#include <visualization_msgs/msg/marker_array.hpp>
2727

28-
#include <image_geometry/pinhole_camera_model.h>
28+
#if __has_include(<image_geometry/pinhole_camera_model.hpp>)
29+
#include <image_geometry/pinhole_camera_model.hpp> // for ROS 2 Jazzy or newer
30+
#else
31+
#include <image_geometry/pinhole_camera_model.h> // for ROS 2 Humble or older
32+
#endif
33+
2934
#include <lanelet2_core/LaneletMap.h>
3035
#include <lanelet2_routing/RoutingGraph.h>
3136
#include <lanelet2_traffic_rules/TrafficRulesFactory.h>

perception/traffic_light_occlusion_predictor/include/traffic_light_occlusion_predictor/nodelet.hpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@
2727
#include <tier4_perception_msgs/msg/traffic_light_array.hpp>
2828
#include <tier4_perception_msgs/msg/traffic_light_roi_array.hpp>
2929

30-
#include <image_geometry/pinhole_camera_model.h>
30+
#if __has_include(<image_geometry/pinhole_camera_model.hpp>)
31+
#include <image_geometry/pinhole_camera_model.hpp> // for ROS 2 Jazzy or newer
32+
#else
33+
#include <image_geometry/pinhole_camera_model.h> // for ROS 2 Humble or older
34+
#endif
35+
3136
#include <message_filters/subscriber.h>
3237
#include <message_filters/synchronizer.h>
3338
#include <message_filters/time_synchronizer.h>

perception/traffic_light_occlusion_predictor/include/traffic_light_occlusion_predictor/occlusion_predictor.hpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@
2424
#include <sensor_msgs/msg/point_cloud2.hpp>
2525
#include <tier4_perception_msgs/msg/traffic_light_roi_array.hpp>
2626

27-
#include <image_geometry/pinhole_camera_model.h>
27+
#if __has_include(<image_geometry/pinhole_camera_model.hpp>)
28+
#include <image_geometry/pinhole_camera_model.hpp> // for ROS 2 Jazzy or newer
29+
#else
30+
#include <image_geometry/pinhole_camera_model.h> // for ROS 2 Humble or older
31+
#endif
32+
2833
#include <lanelet2_core/Forward.h>
2934
#include <pcl/common/transforms.h>
3035
#include <pcl/point_cloud.h>

perception/traffic_light_visualization/include/traffic_light_visualization/traffic_light_roi_visualizer/nodelet.hpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
#include <tier4_perception_msgs/msg/traffic_light_array.hpp>
2424
#include <tier4_perception_msgs/msg/traffic_light_roi_array.hpp>
2525

26-
#include <cv_bridge/cv_bridge.h>
26+
#if __has_include(<cv_bridge/cv_bridge.hpp>)
27+
#include <cv_bridge/cv_bridge.hpp> // for ROS 2 Jazzy or newer
28+
#else
29+
#include <cv_bridge/cv_bridge.h> // for ROS 2 Humble or older
30+
#endif
2731
#include <message_filters/subscriber.h>
2832
#include <message_filters/sync_policies/approximate_time.h>
2933
#include <message_filters/synchronizer.h>

0 commit comments

Comments
 (0)