Skip to content

Commit 8992d05

Browse files
chore(object_merger): rework parameters (#6160)
* chore(object_merger): parametrize some parameters Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * revert priority_mode Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent a1d8321 commit 8992d05

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

launch/tier4_perception_launch/launch/object_recognition/detection/merger/lidar_merger.launch.xml

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
<include file="$(find-pkg-share object_merger)/launch/object_association_merger.launch.xml">
4646
<arg name="input/object0" value="$(var merger/input/objects)"/>
4747
<arg name="input/object1" value="clustering/objects"/>
48+
<arg name="priority_mode" value="2"/>
4849
<arg name="output/object" value="$(var merger/output/objects)"/>
4950
<arg name="data_association_matrix_path" value="$(var object_recognition_detection_object_merger_data_association_matrix_param_path)"/>
5051
<arg name="distance_threshold_list_path" value="$(var object_recognition_detection_object_merger_distance_threshold_list_path)"/>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
/**:
2+
ros__parameters:
3+
sync_queue_size: 20
4+
precision_threshold_to_judge_overlapped: 0.4
5+
remove_overlapped_unknown_objects: true

perception/object_merger/launch/object_association_merger.launch.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@
66
<arg name="priority_mode" default="2" description="0: Object0, 1: Object1, 2: Confidence"/>
77
<arg name="data_association_matrix_path" default="$(find-pkg-share object_merger)/config/data_association_matrix.param.yaml"/>
88
<arg name="distance_threshold_list_path" default="$(find-pkg-share object_merger)/config/overlapped_judge.param.yaml"/>
9-
<arg name="sync_queue_size" default="20"/>
9+
<arg name="object_association_merger_param_path" default="$(find-pkg-share object_merger)/config/object_association_merger.param.yaml"/>
1010

1111
<node pkg="object_merger" exec="object_association_merger_node" name="$(anon object_association_merger)" output="screen">
1212
<remap from="input/object0" to="$(var input/object0)"/>
1313
<remap from="input/object1" to="$(var input/object1)"/>
1414
<remap from="output/object" to="$(var output/object)"/>
1515
<param from="$(var data_association_matrix_path)"/>
1616
<param from="$(var distance_threshold_list_path)"/>
17+
<param from="$(var object_association_merger_param_path)"/>
18+
19+
<!-- Be careful when moving this parameter to param.yaml, since this value depends on which part this launcher is called -->
1720
<param name="priority_mode" value="$(var priority_mode)"/>
18-
<param name="sync_queue_size" value="$(var sync_queue_size)"/>
19-
<param name="precision_threshold_to_judge_overlapped" value="0.4"/>
20-
<param name="remove_overlapped_unknown_objects" value="true"/>
2121
</node>
2222
</launch>

0 commit comments

Comments
 (0)