fix(image_projection_based_fusion): fix spell check minx -> min_x etc

Author: h-ohta

perception/image_projection_based_fusion/config/segmentation_pointcloud_fusion.param.yaml

@@ -31,10 +31,10 @@
 
     # debug
     debug_mode: false
-    filter_scope_minx: -100
-    filter_scope_maxx: 100
-    filter_scope_miny: -100
-    filter_scope_maxy: 100
-    filter_scope_minz: -100
-    filter_scope_maxz: 100
+    filter_scope_min_x: -100
+    filter_scope_max_x: 100
+    filter_scope_min_y: -100
+    filter_scope_max_y: 100
+    filter_scope_min_z: -100
+    filter_scope_max_z: 100
     image_buffer_size: 15

perception/image_projection_based_fusion/include/image_projection_based_fusion/fusion_node.hpp

@@ -44,8 +44,6 @@
 #include <utility>
 #include <vector>
 
-// cspell: ignore minx, maxx, miny, maxy, minz, maxz
-
 namespace image_projection_based_fusion
 {
 using autoware_auto_perception_msgs::msg::DetectedObject;
@@ -131,13 +129,12 @@ class FusionNode : public rclcpp::Node
   // debugger
   std::shared_ptr<Debugger> debugger_;
   virtual bool out_of_scope(const ObjType & obj) = 0;
-  // cspell: ignore minx, maxx, miny, maxy, minz, maxz
-  float filter_scope_minx_;
-  float filter_scope_maxx_;
-  float filter_scope_miny_;
-  float filter_scope_maxy_;
-  float filter_scope_minz_;
-  float filter_scope_maxz_;
+  float filter_scope_min_x_;
+  float filter_scope_max_x_;
+  float filter_scope_min_y_;
+  float filter_scope_max_y_;
+  float filter_scope_min_z_;
+  float filter_scope_max_z_;
 
   /** \brief processing time publisher. **/
   std::unique_ptr<tier4_autoware_utils::StopWatch<std::chrono::milliseconds>> stop_watch_ptr_;

perception/image_projection_based_fusion/launch/roi_cluster_fusion.launch.xml

@@ -22,7 +22,6 @@
   <arg name="sync_param_path" default="$(find-pkg-share image_projection_based_fusion)/config/roi_sync.param.yaml"/>
 
   <!-- debug -->
-  <!-- cspell: ignore minx, maxx, miny, maxy, minz, maxz  -->
   <arg name="input/image0" default="/image_raw0"/>
   <arg name="input/image1" default="/image_raw1"/>
   <arg name="input/image2" default="/image_raw2"/>

perception/image_projection_based_fusion/src/fusion_node.cpp

@@ -137,14 +137,12 @@ FusionNode<Msg, ObjType, Msg2D>::FusionNode(
     stop_watch_ptr_->tic("processing_time");
   }
 
-  // cspell: ignore minx, maxx, miny, maxy, minz, maxz
-  // FIXME: use min_x instead of minx
-  filter_scope_minx_ = declare_parameter<double>("filter_scope_min_x");
-  filter_scope_maxx_ = declare_parameter<double>("filter_scope_max_x");
-  filter_scope_miny_ = declare_parameter<double>("filter_scope_min_y");
-  filter_scope_maxy_ = declare_parameter<double>("filter_scope_max_y");
-  filter_scope_minz_ = declare_parameter<double>("filter_scope_min_z");
-  filter_scope_maxz_ = declare_parameter<double>("filter_scope_max_z");
+  filter_scope_min_x_ = declare_parameter<double>("filter_scope_min_x");
+  filter_scope_max_x_ = declare_parameter<double>("filter_scope_max_x");
+  filter_scope_min_y_ = declare_parameter<double>("filter_scope_min_y");
+  filter_scope_max_y_ = declare_parameter<double>("filter_scope_max_y");
+  filter_scope_min_z_ = declare_parameter<double>("filter_scope_min_z");
+  filter_scope_max_z_ = declare_parameter<double>("filter_scope_max_z");
 }
 
 template <class Msg, class Obj, class Msg2D>

perception/image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

@@ -28,8 +28,6 @@
 #include <tf2_sensor_msgs/tf2_sensor_msgs.hpp>
 #endif
 
-// cspell: ignore minx, maxx, miny, maxy, minz, maxz
-
 namespace image_projection_based_fusion
 {
 
@@ -253,17 +251,17 @@ bool RoiClusterFusionNode::out_of_scope(const DetectedObjectWithFeature & obj)
   for (sensor_msgs::PointCloud2ConstIterator<float> iter_x(cluster, "x"), iter_y(cluster, "y"),
        iter_z(cluster, "z");
        iter_x != iter_x.end(); ++iter_x, ++iter_y, ++iter_z) {
-    if (!valid_point(*iter_x, filter_scope_minx_, filter_scope_maxx_)) {
+    if (!valid_point(*iter_x, filter_scope_min_x_, filter_scope_max_x_)) {
       is_out = true;
       break;
     }
 
-    if (!valid_point(*iter_y, filter_scope_miny_, filter_scope_maxy_)) {
+    if (!valid_point(*iter_y, filter_scope_min_y_, filter_scope_max_y_)) {
       is_out = true;
       break;
     }
 
-    if (!valid_point(*iter_z, filter_scope_minz_, filter_scope_maxz_)) {
+    if (!valid_point(*iter_z, filter_scope_min_z_, filter_scope_max_z_)) {
       is_out = true;
       break;
     }

perception/image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp

@@ -19,8 +19,6 @@
 #include <image_projection_based_fusion/utils/geometry.hpp>
 #include <image_projection_based_fusion/utils/utils.hpp>
 
-// cspell: ignore minx, maxx, miny, maxy, minz, maxz
-
 namespace image_projection_based_fusion
 {
 
@@ -268,13 +266,13 @@ bool RoiDetectedObjectFusionNode::out_of_scope(const DetectedObject & obj)
     return (p > min_num) && (p < max_num);
   };
 
-  if (!valid_point(pose.position.x, filter_scope_minx_, filter_scope_maxx_)) {
+  if (!valid_point(pose.position.x, filter_scope_min_x_, filter_scope_max_x_)) {
     return is_out;
   }
-  if (!valid_point(pose.position.y, filter_scope_miny_, filter_scope_maxy_)) {
+  if (!valid_point(pose.position.y, filter_scope_min_y_, filter_scope_max_y_)) {
     return is_out;
   }
-  if (!valid_point(pose.position.z, filter_scope_minz_, filter_scope_maxz_)) {
+  if (!valid_point(pose.position.z, filter_scope_min_z_, filter_scope_max_z_)) {
     return is_out;
   }