Skip to content

Commit 889bdb0

Browse files
committed
fix(image_projection_based_fusion): fix spell check minx -> min_x etc
1 parent 0d10e81 commit 889bdb0

File tree

6 files changed

+24
-34
lines changed

6 files changed

+24
-34
lines changed

perception/image_projection_based_fusion/config/segmentation_pointcloud_fusion.param.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131

3232
# debug
3333
debug_mode: false
34-
filter_scope_minx: -100
35-
filter_scope_maxx: 100
36-
filter_scope_miny: -100
37-
filter_scope_maxy: 100
38-
filter_scope_minz: -100
39-
filter_scope_maxz: 100
34+
filter_scope_min_x: -100
35+
filter_scope_max_x: 100
36+
filter_scope_min_y: -100
37+
filter_scope_max_y: 100
38+
filter_scope_min_z: -100
39+
filter_scope_max_z: 100
4040
image_buffer_size: 15

perception/image_projection_based_fusion/include/image_projection_based_fusion/fusion_node.hpp

+6-9
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@
4444
#include <utility>
4545
#include <vector>
4646

47-
// cspell: ignore minx, maxx, miny, maxy, minz, maxz
48-
4947
namespace image_projection_based_fusion
5048
{
5149
using autoware_auto_perception_msgs::msg::DetectedObject;
@@ -131,13 +129,12 @@ class FusionNode : public rclcpp::Node
131129
// debugger
132130
std::shared_ptr<Debugger> debugger_;
133131
virtual bool out_of_scope(const ObjType & obj) = 0;
134-
// cspell: ignore minx, maxx, miny, maxy, minz, maxz
135-
float filter_scope_minx_;
136-
float filter_scope_maxx_;
137-
float filter_scope_miny_;
138-
float filter_scope_maxy_;
139-
float filter_scope_minz_;
140-
float filter_scope_maxz_;
132+
float filter_scope_min_x_;
133+
float filter_scope_max_x_;
134+
float filter_scope_min_y_;
135+
float filter_scope_max_y_;
136+
float filter_scope_min_z_;
137+
float filter_scope_max_z_;
141138

142139
/** \brief processing time publisher. **/
143140
std::unique_ptr<tier4_autoware_utils::StopWatch<std::chrono::milliseconds>> stop_watch_ptr_;

perception/image_projection_based_fusion/launch/roi_cluster_fusion.launch.xml

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
<arg name="sync_param_path" default="$(find-pkg-share image_projection_based_fusion)/config/roi_sync.param.yaml"/>
2323

2424
<!-- debug -->
25-
<!-- cspell: ignore minx, maxx, miny, maxy, minz, maxz -->
2625
<arg name="input/image0" default="/image_raw0"/>
2726
<arg name="input/image1" default="/image_raw1"/>
2827
<arg name="input/image2" default="/image_raw2"/>

perception/image_projection_based_fusion/src/fusion_node.cpp

+6-8
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,12 @@ FusionNode<Msg, ObjType, Msg2D>::FusionNode(
137137
stop_watch_ptr_->tic("processing_time");
138138
}
139139

140-
// cspell: ignore minx, maxx, miny, maxy, minz, maxz
141-
// FIXME: use min_x instead of minx
142-
filter_scope_minx_ = declare_parameter<double>("filter_scope_min_x");
143-
filter_scope_maxx_ = declare_parameter<double>("filter_scope_max_x");
144-
filter_scope_miny_ = declare_parameter<double>("filter_scope_min_y");
145-
filter_scope_maxy_ = declare_parameter<double>("filter_scope_max_y");
146-
filter_scope_minz_ = declare_parameter<double>("filter_scope_min_z");
147-
filter_scope_maxz_ = declare_parameter<double>("filter_scope_max_z");
140+
filter_scope_min_x_ = declare_parameter<double>("filter_scope_min_x");
141+
filter_scope_max_x_ = declare_parameter<double>("filter_scope_max_x");
142+
filter_scope_min_y_ = declare_parameter<double>("filter_scope_min_y");
143+
filter_scope_max_y_ = declare_parameter<double>("filter_scope_max_y");
144+
filter_scope_min_z_ = declare_parameter<double>("filter_scope_min_z");
145+
filter_scope_max_z_ = declare_parameter<double>("filter_scope_max_z");
148146
}
149147

150148
template <class Msg, class Obj, class Msg2D>

perception/image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
#include <tf2_sensor_msgs/tf2_sensor_msgs.hpp>
2929
#endif
3030

31-
// cspell: ignore minx, maxx, miny, maxy, minz, maxz
32-
3331
namespace image_projection_based_fusion
3432
{
3533

@@ -253,17 +251,17 @@ bool RoiClusterFusionNode::out_of_scope(const DetectedObjectWithFeature & obj)
253251
for (sensor_msgs::PointCloud2ConstIterator<float> iter_x(cluster, "x"), iter_y(cluster, "y"),
254252
iter_z(cluster, "z");
255253
iter_x != iter_x.end(); ++iter_x, ++iter_y, ++iter_z) {
256-
if (!valid_point(*iter_x, filter_scope_minx_, filter_scope_maxx_)) {
254+
if (!valid_point(*iter_x, filter_scope_min_x_, filter_scope_max_x_)) {
257255
is_out = true;
258256
break;
259257
}
260258

261-
if (!valid_point(*iter_y, filter_scope_miny_, filter_scope_maxy_)) {
259+
if (!valid_point(*iter_y, filter_scope_min_y_, filter_scope_max_y_)) {
262260
is_out = true;
263261
break;
264262
}
265263

266-
if (!valid_point(*iter_z, filter_scope_minz_, filter_scope_maxz_)) {
264+
if (!valid_point(*iter_z, filter_scope_min_z_, filter_scope_max_z_)) {
267265
is_out = true;
268266
break;
269267
}

perception/image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
#include <image_projection_based_fusion/utils/geometry.hpp>
2020
#include <image_projection_based_fusion/utils/utils.hpp>
2121

22-
// cspell: ignore minx, maxx, miny, maxy, minz, maxz
23-
2422
namespace image_projection_based_fusion
2523
{
2624

@@ -268,13 +266,13 @@ bool RoiDetectedObjectFusionNode::out_of_scope(const DetectedObject & obj)
268266
return (p > min_num) && (p < max_num);
269267
};
270268

271-
if (!valid_point(pose.position.x, filter_scope_minx_, filter_scope_maxx_)) {
269+
if (!valid_point(pose.position.x, filter_scope_min_x_, filter_scope_max_x_)) {
272270
return is_out;
273271
}
274-
if (!valid_point(pose.position.y, filter_scope_miny_, filter_scope_maxy_)) {
272+
if (!valid_point(pose.position.y, filter_scope_min_y_, filter_scope_max_y_)) {
275273
return is_out;
276274
}
277-
if (!valid_point(pose.position.z, filter_scope_minz_, filter_scope_maxz_)) {
275+
if (!valid_point(pose.position.z, filter_scope_min_z_, filter_scope_max_z_)) {
278276
return is_out;
279277
}
280278

0 commit comments

Comments
 (0)