fix(autoware_behavior_velocity_planner): fix some clang-tidy errors

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

Author: esteve

planning/behavior_velocity_planner/src/node.cpp

@@ -152,7 +152,7 @@ BehaviorVelocityPlannerNode::BehaviorVelocityPlannerNode(const rclcpp::NodeOptio
   // Initialize PlannerManager
   for (const auto & name : declare_parameter<std::vector<std::string>>("launch_modules")) {
     // workaround: Since ROS 2 can't get empty list, launcher set [''] on the parameter.
-    if (name == "") {
+    if (name.empty()) {
       break;
     }
     planner_manager_.launchScenePlugin(*this, name);
@@ -180,7 +180,7 @@ void BehaviorVelocityPlannerNode::onUnloadPlugin(
 
 // NOTE: argument planner_data must not be referenced for multithreading
 bool BehaviorVelocityPlannerNode::isDataReady(
-  const PlannerData planner_data, rclcpp::Clock clock) const
+  const PlannerData& planner_data, rclcpp::Clock clock) const
 {
   const auto & d = planner_data;
 

planning/behavior_velocity_planner/src/node.hpp

@@ -44,9 +44,7 @@
 #include <string>
 #include <vector>
 
-namespace autoware
-{
-namespace behavior_velocity_planner
+namespace autoware::behavior_velocity_planner
 {
 using autoware_auto_mapping_msgs::msg::HADMapBin;
 using autoware_behavior_velocity_planner::srv::LoadPlugin;
@@ -114,7 +112,7 @@ class BehaviorVelocityPlannerNode : public rclcpp::Node
   BehaviorVelocityPlannerManager planner_manager_;
   bool is_driving_forward_{true};
   HADMapBin::ConstSharedPtr map_ptr_{nullptr};
-  bool has_received_map_;
+  bool has_received_map_{};
 
   rclcpp::Service<LoadPlugin>::SharedPtr srv_load_plugin_;
   rclcpp::Service<UnloadPlugin>::SharedPtr srv_unload_plugin_;
@@ -129,7 +127,7 @@ class BehaviorVelocityPlannerNode : public rclcpp::Node
 
   // function
   geometry_msgs::msg::PoseStamped getCurrentPose();
-  bool isDataReady(const PlannerData planner_data, rclcpp::Clock clock) const;
+  bool isDataReady(const PlannerData & planner_data, rclcpp::Clock clock) const;
   autoware_auto_planning_msgs::msg::Path generatePath(
     const autoware_auto_planning_msgs::msg::PathWithLaneId::ConstSharedPtr input_path_msg,
     const PlannerData & planner_data);
@@ -138,7 +136,6 @@ class BehaviorVelocityPlannerNode : public rclcpp::Node
 
   std::unique_ptr<tier4_autoware_utils::PublishedTimePublisher> published_time_publisher_;
 };
-}  // namespace behavior_velocity_planner
 }  // namespace autoware
 
 #endif  // NODE_HPP_

planning/behavior_velocity_planner/src/planner_manager.cpp

@@ -83,7 +83,7 @@ void BehaviorVelocityPlannerManager::removeScenePlugin(
 {
   auto it = std::remove_if(
     scene_manager_plugins_.begin(), scene_manager_plugins_.end(),
-    [&](const std::shared_ptr<autoware::behavior_velocity_planner::PluginInterface> plugin) {
+    [&](const std::shared_ptr<autoware::behavior_velocity_planner::PluginInterface>& plugin) {
       return plugin->getModuleName() == name;
     });
 

planning/behavior_velocity_planner/src/planner_manager.hpp

@@ -36,9 +36,7 @@
 #include <string>
 #include <vector>
 
-namespace autoware
-{
-namespace behavior_velocity_planner
+namespace autoware::behavior_velocity_planner
 {
 using ::behavior_velocity_planner::PlannerData;
 using ::behavior_velocity_planner::PluginInterface;
@@ -61,7 +59,6 @@ class BehaviorVelocityPlannerManager
   pluginlib::ClassLoader<PluginInterface> plugin_loader_;
   std::vector<std::shared_ptr<PluginInterface>> scene_manager_plugins_;
 };
-}  // namespace behavior_velocity_planner
 }  // namespace autoware
 
 #endif  // PLANNER_MANAGER_HPP_