Skip to content

Commit 56f29fe

Browse files
feat: apply autoware_ prefix for duplicated_node_checker (#9970)
* feat(duplicated_node_checker): apply `autoware_` prefix (see below): Note: * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * rename(duplicated_node_checker): move a header under `include/autoware`: * Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * fix(duplicated_node_checker): fix include header path * To follow the previous commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * rename: `duplicated_node_checker` => `autoware_duplicated_node_checker` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * style(pre-commit): autofix * bug(autoware_duplicated_node_checker): revert wrongly updated copyrights Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * update(autoware_duplicated_node_checker): `README.md` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> * update: `CODEOWNERS` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> --------- Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 8418ae9 commit 56f29fe

File tree

11 files changed

+24
-23
lines changed

11 files changed

+24
-23
lines changed

.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ system/diagnostic_graph_aggregator/** isamu.takagi@tier4.jp
219219
system/diagnostic_graph_utils/** isamu.takagi@tier4.jp
220220
system/autoware_dummy_diag_publisher/** fumihito.ito@tier4.jp tetsuhiro.kawaguchi@tier4.jp
221221
system/dummy_infrastructure/** ryohsuke.mitsudome@tier4.jp
222-
system/duplicated_node_checker/** mamoru.sobue@tier4.jp shumpei.wakabayashi@tier4.jp uken.ryu@tier4.jp
222+
system/autoware_duplicated_node_checker/** mamoru.sobue@tier4.jp shumpei.wakabayashi@tier4.jp uken.ryu@tier4.jp junya.sasaki@tier4.jp
223223
system/hazard_status_converter/** isamu.takagi@tier4.jp
224224
system/mrm_comfortable_stop_operator/** makoto.kurihara@tier4.jp tomohito.ando@tier4.jp
225225
system/mrm_emergency_stop_operator/** makoto.kurihara@tier4.jp tomohito.ando@tier4.jp

system/duplicated_node_checker/CMakeLists.txt system/autoware_duplicated_node_checker/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.14)
2-
project(duplicated_node_checker)
2+
project(autoware_duplicated_node_checker)
33

44
find_package(autoware_cmake REQUIRED)
55
autoware_package()
@@ -10,8 +10,8 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
1010
)
1111

1212
rclcpp_components_register_node(${PROJECT_NAME}
13-
PLUGIN "duplicated_node_checker::DuplicatedNodeChecker"
14-
EXECUTABLE duplicated_node_checker_node
13+
PLUGIN "autoware::duplicated_node_checker::DuplicatedNodeChecker"
14+
EXECUTABLE ${PROJECT_NAME}_node
1515
)
1616

1717
ament_auto_package(INSTALL_TO_SHARE

system/duplicated_node_checker/README.md system/autoware_duplicated_node_checker/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The result is published as diagnostics.
88
### Standalone Startup
99

1010
```bash
11-
ros2 launch duplicated_node_checker duplicated_node_checker.launch.xml
11+
ros2 launch autoware_duplicated_node_checker duplicated_node_checker.launch.xml
1212
```
1313

1414
## Inner-workings / Algorithms
@@ -30,7 +30,7 @@ The types of topic status and corresponding diagnostic status are following.
3030

3131
## Parameters
3232

33-
{{ json_to_markdown("system/duplicated_node_checker/schema/duplicated_node_checker.schema.json") }}
33+
{{ json_to_markdown("system/autoware_duplicated_node_checker/schema/duplicated_node_checker.schema.json") }}
3434

3535
## Assumptions / Known limits
3636

system/duplicated_node_checker/include/duplicated_node_checker/duplicated_node_checker_core.hpp system/autoware_duplicated_node_checker/include/autoware/duplicated_node_checker/duplicated_node_checker_core.hpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
#ifndef DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
16-
#define DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
15+
#ifndef AUTOWARE__DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
16+
#define AUTOWARE__DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
1717

1818
#include <diagnostic_updater/diagnostic_updater.hpp>
1919
#include <rclcpp/rclcpp.hpp>
@@ -22,7 +22,7 @@
2222
#include <unordered_set>
2323
#include <vector>
2424

25-
namespace duplicated_node_checker
25+
namespace autoware::duplicated_node_checker
2626
{
2727
class DuplicatedNodeChecker : public rclcpp::Node
2828
{
@@ -54,6 +54,6 @@ class DuplicatedNodeChecker : public rclcpp::Node
5454
bool add_duplicated_node_names_to_msg_;
5555
std::unordered_set<std::string> nodes_to_ignore_;
5656
};
57-
} // namespace duplicated_node_checker
57+
} // namespace autoware::duplicated_node_checker
5858

59-
#endif // DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
59+
#endif // AUTOWARE__DUPLICATED_NODE_CHECKER__DUPLICATED_NODE_CHECKER_CORE_HPP_
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<launch>
2+
<arg name="config_file" default="$(find-pkg-share autoware_duplicated_node_checker)/config/duplicated_node_checker.param.yaml"/>
3+
4+
<node pkg="autoware_duplicated_node_checker" exec="autoware_duplicated_node_checker_node" name="duplicated_node_checker" output="screen">
5+
<param from="$(var config_file)"/>
6+
</node>
7+
</launch>

system/duplicated_node_checker/package.xml system/autoware_duplicated_node_checker/package.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
<?xml version="1.0"?>
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
4-
<name>duplicated_node_checker</name>
4+
<name>autoware_duplicated_node_checker</name>
55
<version>0.40.0</version>
66
<description>A package to find out nodes with common names</description>
77
<maintainer email="shumpei.wakabayashi@tier4.jp">Shumpei Wakabayashi</maintainer>
88
<maintainer email="uken.ryu@tier4.jp">yliuhb</maintainer>
99
<maintainer email="mamoru.sobue@tier4.jp">Mamoru Sobue</maintainer>
10+
<maintainer email="junya.sasaki@tier4.jp">Junya Sasaki</maintainer>
1011
<license>Apache 2.0</license>
1112

1213
<buildtool_depend>ament_cmake</buildtool_depend>

system/duplicated_node_checker/src/duplicated_node_checker_core.cpp system/autoware_duplicated_node_checker/src/duplicated_node_checker_core.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
#include "duplicated_node_checker/duplicated_node_checker_core.hpp"
15+
#include "autoware/duplicated_node_checker/duplicated_node_checker_core.hpp"
1616

1717
#include <diagnostic_updater/diagnostic_updater.hpp>
1818
#include <rclcpp/rclcpp.hpp>
@@ -22,7 +22,7 @@
2222
#include <string>
2323
#include <vector>
2424

25-
namespace duplicated_node_checker
25+
namespace autoware::duplicated_node_checker
2626
{
2727

2828
DuplicatedNodeChecker::DuplicatedNodeChecker(const rclcpp::NodeOptions & node_options)
@@ -77,7 +77,7 @@ void DuplicatedNodeChecker::produceDiagnostics(diagnostic_updater::DiagnosticSta
7777
stat.summary(level, msg);
7878
}
7979

80-
} // namespace duplicated_node_checker
80+
} // namespace autoware::duplicated_node_checker
8181

8282
#include <rclcpp_components/register_node_macro.hpp>
83-
RCLCPP_COMPONENTS_REGISTER_NODE(duplicated_node_checker::DuplicatedNodeChecker)
83+
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::duplicated_node_checker::DuplicatedNodeChecker)

system/duplicated_node_checker/launch/duplicated_node_checker.launch.xml

-7
This file was deleted.

0 commit comments

Comments
 (0)