fix(autoware_compare_map_segmentation): fix cppcheck constVariableReference (#9196)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

Author: veqcc

perception/autoware_compare_map_segmentation/src/voxel_grid_map_loader/voxel_grid_map_loader.hpp

@@ -207,10 +207,13 @@ class VoxelGridDynamicMapLoader : public VoxelGridMapLoader
   }
   inline std::vector<std::string> getCurrentMapIDs()
   {
-    std::vector<std::string> current_map_ids{};
-    std::lock_guard<std::mutex> lock(dynamic_map_loader_mutex_);
-    for (auto & kv : current_voxel_grid_dict_) {
-      current_map_ids.push_back(kv.first);
+    std::vector<std::string> current_map_ids;
+    {
+      std::lock_guard<std::mutex> lock(dynamic_map_loader_mutex_);
+      current_map_ids.reserve(current_voxel_grid_dict_.size());
+      for (const auto & kv : current_voxel_grid_dict_) {
+        current_map_ids.push_back(kv.first);
+      }
     }
     return current_map_ids;
   }