Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get function in data_store.py #744

Closed
3 tasks
wanglec opened this issue Apr 18, 2022 · 0 comments · Fixed by #769
Closed
3 tasks

Fix get function in data_store.py #744

wanglec opened this issue Apr 18, 2022 · 0 comments · Fixed by #769
Assignees

Comments

@wanglec
Copy link
Collaborator

wanglec commented Apr 18, 2022

Is your feature request related to a problem? Please describe.
The current implementation of the get function has three problems.

  • First, it does not generate annotation-like entries with correct begin/end order, will address in Let get function take range annotation #769
  • Second, it does not have a defined order for non-annotation-like types.
  • Third, it does not cache the find subtype function.

Depends on

  • List issues that this one depends on.

Describe the solution you'd like
We may use the co_iterator_annotation_like function to solve the first problem.
To solve the second problem, we may sort all subtypes and subsequently generate entries belonging to each subtype.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
  • After the data tuple class is finished, we may switch to a new branch for integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant