Add support to run RemoteStoreIT with S3 integration

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Author: ashking94

plugins/repository-s3/build.gradle

@@ -141,6 +141,7 @@ test {
   // this is tested explicitly in separate test tasks
   exclude '**/RepositoryCredentialsTests.class'
   exclude '**/S3RepositoryThirdPartyTests.class'
+  exclude '**/S3RemoteStoreIT.class'
 }
 
 boolean useFixture = false
@@ -252,6 +253,7 @@ processYamlRestTestResources {
 internalClusterTest {
   // this is tested explicitly in a separate test task
   exclude '**/S3RepositoryThirdPartyTests.class'
+  exclude '**/S3RemoteStoreIT.class'
 }
 
 yamlRestTest {
@@ -408,6 +410,7 @@ TaskProvider s3ThirdPartyTest = tasks.register("s3ThirdPartyTest", Test) {
   setTestClassesDirs(internalTestSourceSet.getOutput().getClassesDirs())
   setClasspath(internalTestSourceSet.getRuntimeClasspath())
   include '**/S3RepositoryThirdPartyTests.class'
+  include '**/S3RemoteStoreIT.class'
   systemProperty 'test.s3.account', s3PermanentAccessKey
   systemProperty 'test.s3.key', s3PermanentSecretKey
   systemProperty 'test.s3.bucket', s3PermanentBucket

plugins/repository-s3/src/internalClusterTest/java/org/opensearch/repositories/s3/S3RemoteStoreIT.java

@@ -392,7 +392,7 @@ private <T> T getFutureValue(PlainActionFuture<T> future) throws IOException {
             return future.get();
         } catch (InterruptedException e) {
             Thread.currentThread().interrupt();
-            throw new IllegalStateException("Future got interrupted", e);
+            throw new IOException("Future got interrupted", e);
         } catch (ExecutionException e) {
             if (e.getCause() instanceof IOException) {
                 throw (IOException) e.getCause();

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3BlobContainer.java

@@ -63,7 +63,7 @@
 /**
  * A container for settings used to create an S3 client.
  */
-final class S3ClientSettings {
+public final class S3ClientSettings {
 
     private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(S3ClientSettings.class);
 

plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3ClientSettings.java

@@ -60,6 +60,10 @@ grant {
   permission java.util.PropertyPermission "aws.sharedCredentialsFile", "read,write";
   permission java.util.PropertyPermission "aws.configFile", "read,write";
   permission java.util.PropertyPermission "opensearch.path.conf", "read,write";
+  permission java.util.PropertyPermission "test.s3.account", "read,write";
+  permission java.util.PropertyPermission "test.s3.key", "read,write";
+  permission java.util.PropertyPermission "test.s3.bucket", "read,write";
+  permission java.util.PropertyPermission "test.s3.endpoint", "read,write";
   permission java.io.FilePermission "config", "read";
 
   permission java.lang.RuntimePermission "accessDeclaredMembers";

plugins/repository-s3/src/main/plugin-metadata/plugin-security.policy

@@ -14,7 +14,7 @@
 import org.opensearch.common.unit.TimeValue;
 import org.opensearch.core.common.unit.ByteSizeUnit;
 import org.opensearch.plugins.Plugin;
-import org.opensearch.remotestore.RemoteStoreIT;
+import org.opensearch.remotestore.RemoteStoreBaseIT;
 import org.opensearch.remotestore.multipart.mocks.MockFsRepositoryPlugin;
 import org.opensearch.repositories.RepositoriesService;
 import org.opensearch.repositories.blobstore.BlobStoreRepository;
@@ -34,7 +34,7 @@
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.greaterThan;
 
-public class RemoteStoreMultipartIT extends RemoteStoreIT {
+public class RemoteStoreMultipartBaseIT extends RemoteStoreBaseIT {
 
     Path repositoryLocation;
     boolean compress;

server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreIT.java

@@ -146,7 +146,7 @@ protected void trimUnreferencedReaders(boolean indexDeleted, boolean trimLocal)
 
         // This is to fail fast and avoid listing md files un-necessarily.
         if (indexDeleted == false && RemoteStoreUtils.isPinnedTimestampStateStale()) {
-            logger.warn("Skipping remote translog garbage collection as last fetch of pinned timestamp is stale");
+            logger.debug("Skipping remote translog garbage collection as last fetch of pinned timestamp is stale");
             return;
         }
 
@@ -179,7 +179,7 @@ public void onResponse(List<BlobMetadata> blobMetadata) {
 
                     // Check last fetch status of pinned timestamps. If stale, return.
                     if (indexDeleted == false && RemoteStoreUtils.isPinnedTimestampStateStale()) {
-                        logger.warn("Skipping remote translog garbage collection as last fetch of pinned timestamp is stale");
+                        logger.debug("Skipping remote translog garbage collection as last fetch of pinned timestamp is stale");
                         remoteGenerationDeletionPermits.release(REMOTE_DELETION_PERMITS);
                         return;
                     }