Chore/upgrade nodemailer 6 4 12 (notifme#74)

* upgrade to nodemailer 6.4.12

* fix ses tests

Author: BDav24

__tests__/providers/email/ses.js

@@ -45,7 +45,7 @@ test('SES success with minimal parameters.', async () => {
       Host: 'email.eu-west-1.amazonaws.com',
       'X-Amz-Content-Sha256': [expect.stringMatching(/\w*/)],
       'X-Amz-Date': [datetime],
-      'Content-Length': ['425'],
+      'Content-Length': ['445'],
       'Content-Type': ['application/x-www-form-urlencoded; charset=utf-8'],
       'User-Agent': ['notifme-sdk/v1 (+https://github.com/notifme/notifme-sdk)']
     })
@@ -99,7 +99,7 @@ test('SES success with all parameters.', async () => {
       Host: 'email.eu-west-1.amazonaws.com',
       'X-Amz-Content-Sha256': [expect.stringMatching(/\w*/)],
       'X-Amz-Date': [datetime],
-      'Content-Length': ['1017'],
+      'Content-Length': ['1037'],
       'Content-Type': ['application/x-www-form-urlencoded; charset=utf-8'],
       'User-Agent': ['notifme-sdk/v1 (+https://github.com/notifme/notifme-sdk)']
     })
@@ -121,7 +121,7 @@ test('SES should return an error if a parameter is not of the right type.', asyn
   expect(result).toEqual({
     status: 'error',
     errors: {
-      email: 'The "chunk" argument must be one of type string or Buffer. Received type object'
+      email: expect.stringContaining('The "chunk" argument must be of type string or an instance of Buffer or Uint8Array.')
     },
     channels: {
       email: { id: undefined, providerId: 'email-ses-provider' }

package.json

@@ -26,7 +26,7 @@
     "https-proxy-agent": "5.0.0",
     "node-fetch": "2.6.0",
     "node-pushnotifications": "1.3.0",
-    "nodemailer": "6.4.5",
+    "nodemailer": "6.4.12",
     "web-push": "3.4.3",
     "winston": "3.2.1"
   },

src/providers/email/ses.js

@@ -21,6 +21,17 @@ export default class EmailSesProvider {
   }
 
   async send (request: EmailRequestType): Promise<string> {
+    if (
+      request.text &&
+      typeof request.text !== 'string' &&
+      !(request.text instanceof Buffer) &&
+      !(request.text instanceof Uint8Array)
+    ) {
+      throw new Error(
+        'The "chunk" argument must be of type string or an instance of Buffer or Uint8Array.'
+      )
+    }
+
     const { region } = this.credentials
     const host = `email.${region}.amazonaws.com`
     const raw = (await this.getRaw(
@@ -56,13 +67,9 @@ export default class EmailSesProvider {
     }
   }
 
-  getRaw ({ customize, ...request }: EmailRequestType): Promise<Buffer> {
-    return new Promise((resolve, reject) => {
-      const email = new MailComposer(request).compile()
-      email.keepBcc = true
-      email.build((error, raw) => {
-        error ? reject(error) : resolve(raw)
-      })
-    })
+  async getRaw ({ customize, ...request }: EmailRequestType): Promise<Buffer> {
+    const email = new MailComposer(request).compile()
+    email.keepBcc = true
+    return email.build()
   }
 }

yarn.lock

@@ -4702,10 +4702,10 @@ nodemailer-shared@^1.1.0:
   dependencies:
     nodemailer-fetch "1.6.0"
 
-nodemailer@6.4.5:
-  version "6.4.5"
-  resolved "https://registry.yarnpkg.com/nodemailer/-/nodemailer-6.4.5.tgz#45614c6454d1a947242105eeddae03df87e29916"
-  integrity sha512-NH7aNVQyZLAvGr2+EOto7znvz+qJ02Cb/xpou98ApUt5tEAUSVUxhvHvgV/8I5dhjKTYqUw0nasoKzLNBJKrDQ==
+nodemailer@6.4.12:
+  version "6.4.12"
+  resolved "https://registry.yarnpkg.com/nodemailer/-/nodemailer-6.4.12.tgz#efb3946f3e5c5afad50af8090e070957cea1c43d"
+  integrity sha512-c/WplZp24Lxc+hn0w/kweNxcYGpaqtH1iecfGKTbXVmp5qx+ILApKsmCAucWWIIQiYKKH4ZA/ffSNOsai6xJGA==
 
 nodemon@2.0.2:
   version "2.0.2"