Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change signature of function to set the offset to long #203

Closed
JM-FRANCE opened this issue Mar 8, 2024 · 1 comment · May be fixed by #181
Closed

Change signature of function to set the offset to long #203

JM-FRANCE opened this issue Mar 8, 2024 · 1 comment · May be fixed by #181
Assignees
@per1234
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@JM-FRANCE
Copy link

The function expects an int, yet the instance variable is a long. On some architectures it’s not the same number of bytes

NTPClient/NTPClient.cpp

Line 172 in 01261a9

void NTPClient::setTimeOffset(int timeOffset) {

@JM-FRANCE
Copy link
Author

I had not seen

#181

should be taken into account in the code…

@per1234 per1234 linked a pull request Mar 8, 2024 that will close this issue
Allow setting timeOffset as long (fixes #72 #168) #181
Open
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 8, 2024
@per1234 per1234 self-assigned this Mar 8, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@per1234 per1234

Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting timeOffset as long (fixes #72 #168) Randomblock1/NTPClient
2 participants
@per1234 @JM-FRANCE