Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time offsets >±32,535 seconds still busted in version 3.2.0 #168

Closed
LeMon3half opened this issue Mar 27, 2022 · 1 comment
Closed

Time offsets >±32,535 seconds still busted in version 3.2.0 #168

LeMon3half opened this issue Mar 27, 2022 · 1 comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@LeMon3half
Copy link

Timezone is not working for those of us who live too far from Greenwich...

NTPClient.h line 76
(int timeOffset) should be long, not int

NTPClient.cpp line 143
(int timeOffset) should be long, not int

It works fine after these changes.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 28, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 28, 2022

Thanks for taking the time to submit an issue @LeMon3half .

I see we have another report about this at #72.

Note the latest comment there from one of Arduino's firmware developers:

can you please create a PR containing those changes?

So it seems that a pull request for the proposed changes would be the best way to move this forward.

It is best to have only a single issue per subject so we can consolidate all relevant discussion to one place, so I'll go ahead and close this in favor of the other.

If you end up with additional information to share, feel free to comment in the other thread.

@per1234 per1234 closed this as completed Mar 28, 2022
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Mar 28, 2022
Randomblock1 added a commit to Randomblock1/NTPClient that referenced this issue Oct 27, 2022
@Randomblock1
Allow setting timeOffset as long (fixes arduino-libraries#72 arduino-…
4a9c2aa 
…libraries#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @LeMon3half