Merge branch 'main' into main

Author: ice-coldbell

CHANGELOG.md

@@ -5,6 +5,8 @@ adheres to the format set out by [Keep a Changelog](https://keepachangelog.com/e
 
 # Unreleased
 
+- [`Fix`] Ensure proper cleanup of response body on read error to prevent potential memory leak.
+
 # v1.5.0 (2/10/2024)
 
 - [`Fix`] Make NodeClient match AptosRpcClient interface

nodeClient.go

@@ -1079,11 +1079,11 @@ func Get[T any](rc *NodeClient, getUrl string) (out T, err error) {
 		err = NewHttpError(response)
 		return out, err
 	}
+	defer response.Body.Close()
 	blob, err := io.ReadAll(response.Body)
 	if err != nil {
 		return out, fmt.Errorf("error getting response data, %w", err)
 	}
-	_ = response.Body.Close()
 	err = json.Unmarshal(blob, &out)
 	if err != nil {
 		return out, err
@@ -1114,12 +1114,12 @@ func (rc *NodeClient) GetBCS(getUrl string) (out []byte, err error) {
 		err = NewHttpError(response)
 		return
 	}
+	defer response.Body.Close()
 	blob, err := io.ReadAll(response.Body)
 	if err != nil {
 		err = fmt.Errorf("error getting response data, %w", err)
 		return
 	}
-	_ = response.Body.Close()
 	return blob, nil
 }
 
@@ -1149,12 +1149,12 @@ func Post[T any](rc *NodeClient, postUrl string, contentType string, body io.Rea
 		err = NewHttpError(response)
 		return data, err
 	}
+	defer response.Body.Close()
 	blob, err := io.ReadAll(response.Body)
 	if err != nil {
 		err = fmt.Errorf("error getting response data, %w", err)
 		return data, err
 	}
-	_ = response.Body.Close()
 
 	err = json.Unmarshal(blob, &data)
 	return data, err