Skip to content

Commit c8b06f8

Browse files
authored
Merge branch 'main' into worker-pool-tx
2 parents 51ae856 + 2f4a7b5 commit c8b06f8

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ adheres to the format set out by [Keep a Changelog](https://keepachangelog.com/e
55

66
# Unreleased
77

8+
- [`Fix`] Ensure proper cleanup of response body on read error to prevent potential memory leak.
9+
810
# v1.5.0 (2/10/2024)
911

1012
- [`Fix`] Make NodeClient match AptosRpcClient interface

nodeClient.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -1051,11 +1051,11 @@ func Get[T any](rc *NodeClient, getUrl string) (out T, err error) {
10511051
err = NewHttpError(response)
10521052
return out, err
10531053
}
1054+
defer response.Body.Close()
10541055
blob, err := io.ReadAll(response.Body)
10551056
if err != nil {
10561057
return out, fmt.Errorf("error getting response data, %w", err)
10571058
}
1058-
_ = response.Body.Close()
10591059
err = json.Unmarshal(blob, &out)
10601060
if err != nil {
10611061
return out, err
@@ -1086,12 +1086,12 @@ func (rc *NodeClient) GetBCS(getUrl string) (out []byte, err error) {
10861086
err = NewHttpError(response)
10871087
return
10881088
}
1089+
defer response.Body.Close()
10891090
blob, err := io.ReadAll(response.Body)
10901091
if err != nil {
10911092
err = fmt.Errorf("error getting response data, %w", err)
10921093
return
10931094
}
1094-
_ = response.Body.Close()
10951095
return blob, nil
10961096
}
10971097

@@ -1121,12 +1121,12 @@ func Post[T any](rc *NodeClient, postUrl string, contentType string, body io.Rea
11211121
err = NewHttpError(response)
11221122
return data, err
11231123
}
1124+
defer response.Body.Close()
11241125
blob, err := io.ReadAll(response.Body)
11251126
if err != nil {
11261127
err = fmt.Errorf("error getting response data, %w", err)
11271128
return data, err
11281129
}
1129-
_ = response.Body.Close()
11301130

11311131
err = json.Unmarshal(blob, &data)
11321132
return data, err

0 commit comments

Comments
 (0)