Skip to content

Commit db09ae6

Browse files
isidore4dsherwoodnitsanavnisusanfungTegsy
committed
- r introduced T2
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Nitsan Avni <nitsanav@gmail.com> Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com> Co-Authored-By: T. E. Green <78671457+Tegsy@users.noreply.github.com>
1 parent 601837d commit db09ae6

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

TODO.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
Test are running on all CI machine
22

33
Typing -> Talking -> Next
4-
Susan
54
Llewellyn
65
Teresa
76
Nitsan
87
Diana
8+
Susan
99

1010
We're doing "ping pong style" rotation
1111
Rotate on each successful test run, after **any** smallest improvement to the code
1212
in the direction of te agreed upon intention.
13+
Rotate on green was designed for git handoff, each commit is green
1314

1415
> How do we know that everything works in both Pytest and Unittests?
1516
>

approvaltests/inline/parse.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ def transformer(s: str) -> Tuple[T1, T2]:
6060
# 'int1' is not used, let's start use it
6161
# add in callable
6262
# done: verify_all signature is incorrect
63-
def transform3(self, transform1: Callable[[str], T1], transform2, int1) -> "Parse3[T1, int, int]":
64-
def transformer(s: str) -> Tuple[T1, int, int]:
63+
def transform3(self, transform1: Callable[[str], T1], transform2: Callable[[str], T2], int1) -> "Parse3[T1, int, int]":
64+
def transformer(s: str) -> Tuple[T1, T2, int]:
6565
parts = s.split(",")
6666
parts = list(map(lambda p: p.strip(), parts))
6767
return (transform1(parts[0]), transform2(parts[1]), int(parts[2]))
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
obv, well, change
2+
3+
diana: nitsan tried ping-pong, llewellyn shut up.
4+
like how it's going, need intentions.
5+
6+
Teresa: thanks for making space for learning
7+
feel like we are all a group
8+
9+
Nitsan: can be more in the red. not testing what we are doing?
10+
chat would do this,
11+
can it also do the generic of all.
12+
13+
Susan: I got all the easy tas ks
14+
15+
16+
Llewellyn:
17+
- We're rotating too slow still; with practice it'll get faster
18+
- Like: this style surfaces misunderstandings in the group that might be hidden in our usual way of rotating
19+
- rotate on green was designed for git handoff, each commit is green

0 commit comments

Comments
 (0)