Skip to content

Commit 8befdbe

Browse files
authoredJan 22, 2025
feat: bump mini Ruby version to 3.1 by following core (#1051)
* feat: bump mini Ruby version to 3.1 by following core * modify GHA * fix the reference
1 parent 35edaf4 commit 8befdbe

File tree

8 files changed

+99
-19
lines changed

8 files changed

+99
-19
lines changed
 

‎.github/workflows/functional-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
- name: Set up Ruby
6161
uses: ruby/setup-ruby@v1
6262
with:
63-
ruby-version: 3.2
63+
ruby-version: 3.3
6464
- run: |
6565
bundle install
6666
rake ios

‎.github/workflows/rubocop.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
ruby: [3.0, 3.1, 3.2, 3.3]
14+
ruby: [3.1, 3.2, 3.3]
1515

1616
runs-on: ubuntu-latest
1717

‎.rubocop.yml

+79-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AllCops:
2-
TargetRubyVersion: 3.0
2+
TargetRubyVersion: 3.1
33
Metrics/LineLength:
44
Max: 128
55
Metrics/MethodLength:
@@ -219,3 +219,81 @@ Style/OpenStructUse: # new in 1.23
219219
Enabled: false
220220
Lint/RedundantStringCoercion:
221221
Enabled: false
222+
Gemspec/AddRuntimeDependency: # new in 1.65
223+
Enabled: true
224+
Lint/ConstantReassignment: # new in 1.70
225+
Enabled: true
226+
Lint/DuplicateMatchPattern: # new in 1.50
227+
Enabled: true
228+
Lint/DuplicateSetElement: # new in 1.67
229+
Enabled: true
230+
Lint/HashNewWithKeywordArgumentsAsDefault: # new in 1.69
231+
Enabled: true
232+
Lint/ItWithoutArgumentsInBlock: # new in 1.59
233+
Enabled: true
234+
Lint/LiteralAssignmentInCondition: # new in 1.58
235+
Enabled: true
236+
Lint/MixedCaseRange: # new in 1.53
237+
Enabled: true
238+
Lint/NumericOperationWithConstantResult: # new in 1.69
239+
Enabled: true
240+
Lint/RedundantRegexpQuantifiers: # new in 1.53
241+
Enabled: true
242+
Lint/SharedMutableDefault: # new in 1.70
243+
Enabled: true
244+
Lint/UnescapedBracketInRegexp: # new in 1.68
245+
Enabled: true
246+
Lint/UselessDefined: # new in 1.69
247+
Enabled: true
248+
Lint/UselessNumericOperation: # new in 1.66
249+
Enabled: true
250+
Style/AmbiguousEndlessMethodDefinition: # new in 1.68
251+
Enabled: true
252+
Style/BitwisePredicate: # new in 1.68
253+
Enabled: true
254+
Style/CombinableDefined: # new in 1.68
255+
Enabled: true
256+
Style/DataInheritance: # new in 1.49
257+
Enabled: true
258+
Style/DigChain: # new in 1.69
259+
Enabled: true
260+
Style/ExactRegexpMatch: # new in 1.51
261+
Enabled: true
262+
Style/FileNull: # new in 1.69
263+
Enabled: true
264+
Style/FileTouch: # new in 1.69
265+
Enabled: true
266+
Style/ItAssignment: # new in 1.70
267+
Enabled: true
268+
Style/KeywordArgumentsMerging: # new in 1.68
269+
Enabled: true
270+
Style/MapIntoArray: # new in 1.63
271+
Enabled: true
272+
Style/RedundantArrayConstructor: # new in 1.52
273+
Enabled: true
274+
Style/RedundantCurrentDirectoryInPath: # new in 1.53
275+
Enabled: true
276+
Style/RedundantFilterChain: # new in 1.52
277+
Enabled: true
278+
Style/RedundantInterpolationUnfreeze: # new in 1.66
279+
Enabled: true
280+
Style/RedundantLineContinuation: # new in 1.49
281+
Enabled: true
282+
Style/RedundantRegexpArgument: # new in 1.53
283+
Enabled: true
284+
Style/RedundantRegexpConstructor: # new in 1.52
285+
Enabled: true
286+
Style/ReturnNilInPredicateMethodDefinition: # new in 1.53
287+
Enabled: true
288+
Style/SafeNavigationChainLength: # new in 1.68
289+
Enabled: false
290+
Style/SendWithLiteralMethodName: # new in 1.64
291+
Enabled: true
292+
Style/SingleLineDoEndBlock: # new in 1.57
293+
Enabled: true
294+
Style/SuperArguments: # new in 1.64
295+
Enabled: true
296+
Style/SuperWithArgsParentheses: # new in 1.58
297+
Enabled: true
298+
Style/YAMLFileRead: # new in 1.53
299+
Enabled: true

‎Gemfile

+10
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,13 @@
1414

1515
source 'https://rubygems.org'
1616
gemspec
17+
18+
gem 'appium_thor', '~> 2.0'
19+
gem 'fakefs', '~> 2.8.0'
20+
gem 'hashdiff', '~> 1.1.0'
21+
gem 'minitest', '~> 5.0'
22+
gem 'minitest-reporters', '~> 1.1'
23+
gem 'pry'
24+
gem 'rake', '~> 13.0'
25+
gem 'rubocop', '1.70.0'
26+
gem 'yard', '~> 0.9.11'

‎android_tests/Gemfile

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@
1313
# limitations under the License.
1414

1515
source 'https://rubygems.org'
16-
gemspec path: File.expand_path('..', __dir__) # __dir__ fails on 1.9
16+
gemspec path: File.expand_path('..', __dir__)
17+
eval_gemfile File.join(File.expand_path('..', __dir__), 'Gemfile')

‎appium_lib.gemspec

+4-14
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require_relative 'lib/appium_lib/version'
22

33
Gem::Specification.new do |s|
4-
s.required_ruby_version = '>= 3.0'
4+
s.required_ruby_version = '>= 3.1'
55

66
s.name = 'appium_lib'
77
s.version = Appium::VERSION
@@ -13,19 +13,9 @@ Gem::Specification.new do |s|
1313
s.homepage = 'https://github.com/appium/ruby_lib' # published as appium_lib
1414
s.require_paths = ['lib']
1515

16-
s.add_runtime_dependency 'appium_lib_core', '~> 9.2', '>= 9.2.1'
17-
s.add_runtime_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
18-
s.add_runtime_dependency 'tomlrb', '>= 1.1', '< 3.0'
19-
20-
s.add_development_dependency 'appium_thor', '~> 2.0'
21-
s.add_development_dependency 'fakefs', '~> 2.8.0'
22-
s.add_development_dependency 'hashdiff', '~> 1.1.0'
23-
s.add_development_dependency 'minitest', '~> 5.0'
24-
s.add_development_dependency 'minitest-reporters', '~> 1.1'
25-
s.add_development_dependency 'pry'
26-
s.add_development_dependency 'rake', '~> 13.0'
27-
s.add_development_dependency 'rubocop', '1.70.0'
28-
s.add_development_dependency 'yard', '~> 0.9.11'
16+
s.add_dependency 'appium_lib_core', '~> 9.2', '>= 9.2.1'
17+
s.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
18+
s.add_dependency 'tomlrb', '>= 1.1', '< 3.0'
2919

3020
s.files = `git ls-files`.split("\n").reject { |v| v.match(/\A^(ios_tests|android_tests|grid|test_apps)\/.+/) }
3121
s.metadata['rubygems_mfa_required'] = 'true'

‎ios_tests/Gemfile

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
source 'https://rubygems.org'
1616
gemspec path: File.expand_path('..', __dir__)
17+
eval_gemfile File.join(File.expand_path('..', __dir__), 'Gemfile')
1718

1819
gem 'appium_console'
1920
gem 'parallel_tests'

‎ios_tests/Rakefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ task :run_parallel_t do
9898
require_relative 'parallel/test'
9999

100100
threads = []
101-
[Device.one, Device.two].each do |capability|
101+
[Device.one, Device.two].map do |capability|
102102
threads << Thread.new do
103103
TestParallelRunThread.new(capability).test_run
104104
end

0 commit comments

Comments
 (0)