Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio: Add a UserAgent to the data submitted to the ingress. #733

Closed
abernix opened this issue Mar 24, 2022 · 1 comment · Fixed by #773
Closed

studio: Add a UserAgent to the data submitted to the ingress. #733

abernix opened this issue Mar 24, 2022 · 1 comment · Fixed by #773
Assignees

Comments

@abernix
Copy link
Member

abernix commented Mar 24, 2022

Add a UserAgent to the data submitted to the ingress.apollo-spaceport/src/server.rs:

Name to be finalised, but candidate: ApolloRouterPluginUsageReporting

@abernix abernix changed the title Add a UserAgent to the data submitted to the ingress.apollo-spaceport/src/server.rs:Name to be finalised, but candidate: ApolloRouterPluginUsageReporting studio: Add a UserAgent to the data submitted to the ingress. Mar 24, 2022
@garypen garypen self-assigned this Mar 31, 2022
@garypen
Copy link
Contributor

garypen commented Apr 1, 2022

@glasser Noted that the name ApolloRouterPluginUsageReporting wasn't really descriptive since the spaceport isn't a plugin: "eh, it's not really a plugin? i think it would be fine to say apollo-spaceport or something."

There is a "standard": https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent

and that seems fairly solid, I think having a version in there will pay off in the long term, so:

product: std::env!("CARGO_PKG_NAME"),
version: std::env!("CARGO_PKG_VERSION")
comment: usage reporting

which yields:

user-agent: apollo-spaceport / 0.1.0-preview.1 usage reporting

(which is consistent-ish with the header we put in the actual studio report:

        header.agent_version = format!(
            "{}@{}",
            std::env!("CARGO_PKG_NAME"),
            std::env!("CARGO_PKG_VERSION")
        );

@Geal Geal added this to the v0.1.0-preview.3 milestone Apr 8, 2022
@BrynCooke BrynCooke removed this from the v0.1.0-preview.3 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants