Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deperecation error while installing the site fixed #1132

Closed
wants to merge 1 commit into from

Conversation

sainath1991
Copy link

No description provided.

Copy link

google-cla bot commented Feb 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (99e5633) to head (ca02f74).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #1132      +/-   ##
============================================
- Coverage     44.20%   42.97%   -1.23%     
  Complexity     3041     3041              
============================================
  Files           342      342              
  Lines         11110    11110              
============================================
- Hits           4911     4775     -136     
- Misses         6199     6335     +136     

see 22 files with indirect coverage changes

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainath1991
Thank you for your contribution.

It appears that this PR is incomplete. Could you please update the docblock for the constructor to reflect the new parameter order?
Additionally, ensure that the createInstance method is updated to match the new parameter order in the constructor.

@kedarkhaire
Copy link
Collaborator

Hi @sainath1991
The issue is already fixed in this PR - #1102

We will be releasing a new version in next week which will have this change, so till that time can you use the above patch for your error-free installation.

Closing this PR for now as it won't be required.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants