From abb34842cf0326e4afc439b1d1ea71a31d569a1b Mon Sep 17 00:00:00 2001 From: Kedar Khaire Date: Thu, 9 Jan 2025 12:34:38 +0530 Subject: [PATCH] Fixes for Naming Convention ValidClassName.NoUpperAcronyms PHPCS --- src/Plugin/ApigeeFieldStorageFormat/CSV.php | 2 +- src/Plugin/ApigeeFieldStorageFormat/JSON.php | 2 +- tests/src/Functional/DeveloperAppFieldTest.php | 2 +- tests/src/Functional/DeveloperSyncTest.php | 12 ++++++------ 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Plugin/ApigeeFieldStorageFormat/CSV.php b/src/Plugin/ApigeeFieldStorageFormat/CSV.php index 9d18a9c13..b40bbbe5b 100644 --- a/src/Plugin/ApigeeFieldStorageFormat/CSV.php +++ b/src/Plugin/ApigeeFieldStorageFormat/CSV.php @@ -49,7 +49,7 @@ * * @see https://github.com/symfony/symfony/issues/27447 */ -class CSV implements FieldStorageFormatInterface { +class Csv implements FieldStorageFormatInterface { /** * {@inheritdoc} diff --git a/src/Plugin/ApigeeFieldStorageFormat/JSON.php b/src/Plugin/ApigeeFieldStorageFormat/JSON.php index a4140569b..ffc9bd271 100644 --- a/src/Plugin/ApigeeFieldStorageFormat/JSON.php +++ b/src/Plugin/ApigeeFieldStorageFormat/JSON.php @@ -31,7 +31,7 @@ * weight = 1000, * ) */ -class JSON implements FieldStorageFormatInterface { +class Json implements FieldStorageFormatInterface { /** * {@inheritdoc} diff --git a/tests/src/Functional/DeveloperAppFieldTest.php b/tests/src/Functional/DeveloperAppFieldTest.php index 909c0f064..9012a2556 100644 --- a/tests/src/Functional/DeveloperAppFieldTest.php +++ b/tests/src/Functional/DeveloperAppFieldTest.php @@ -150,7 +150,7 @@ public function testFieldableDeveloperApp() { } /** - * Tests field storage formatters (CSV and JSON). + * Tests field storage formatters (Csv and Json). */ protected function fieldStorageFormattersTest() { $field_name_prefix = (string) $this->config('field_ui.settings')->get('field_prefix'); diff --git a/tests/src/Functional/DeveloperSyncTest.php b/tests/src/Functional/DeveloperSyncTest.php index 7c190c2b9..ebe619c53 100644 --- a/tests/src/Functional/DeveloperSyncTest.php +++ b/tests/src/Functional/DeveloperSyncTest.php @@ -23,8 +23,8 @@ use Drupal\Core\Url; use Drupal\Tests\field_ui\Traits\FieldUiTestTrait; use Drupal\apigee_edge\Entity\Developer; -use Drupal\apigee_edge\Plugin\ApigeeFieldStorageFormat\CSV; -use Drupal\apigee_edge\Plugin\ApigeeFieldStorageFormat\JSON; +use Drupal\apigee_edge\Plugin\ApigeeFieldStorageFormat\Csv; +use Drupal\apigee_edge\Plugin\ApigeeFieldStorageFormat\Json; use Drupal\field\Entity\FieldConfig; use Drupal\field\Entity\FieldStorageConfig; use Drupal\user\Entity\User; @@ -579,11 +579,11 @@ protected function verify() { foreach ($this->fields as $field_type => $data) { $formatter = $this->formatManager->lookupPluginForFieldType($field_type); - if ($formatter instanceof JSON) { + if ($formatter instanceof Json) { $this->assertJsonStringEqualsJsonString($developer->getAttributeValue($data['name']), $formatter->encode($user->get($this->fieldNamePrefix . $data['name'])->getValue())); $this->assertJsonStringEqualsJsonString($developer->getAttributeValue($data['name']), $formatter->encode($data['data_changed'])); } - elseif ($formatter instanceof CSV) { + elseif ($formatter instanceof Csv) { $this->assertEquals($developer->getAttributeValue($data['name']), $formatter->encode($user->get($this->fieldNamePrefix . $data['name'])->getValue())); $this->assertEquals($developer->getAttributeValue($data['name']), $formatter->encode($data['data_changed'])); } @@ -592,11 +592,11 @@ protected function verify() { else { foreach ($this->fields as $field_type => $data) { $formatter = $this->formatManager->lookupPluginForFieldType($field_type); - if ($formatter instanceof JSON) { + if ($formatter instanceof Json) { $this->assertJsonStringEqualsJsonString($developer->getAttributeValue($data['name']), $formatter->encode($user->get($this->fieldNamePrefix . $data['name'])->getValue())); $this->assertJsonStringEqualsJsonString($developer->getAttributeValue($data['name']), $formatter->encode($data['data'])); } - elseif ($formatter instanceof CSV) { + elseif ($formatter instanceof Csv) { $this->assertEquals($developer->getAttributeValue($data['name']), $formatter->encode($user->get($this->fieldNamePrefix . $data['name'])->getValue())); $this->assertEquals($developer->getAttributeValue($data['name']), $formatter->encode($data['data'])); }