You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ published)
19
19
20
20
## Purpose of the PR
21
21
22
-
- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
22
+
- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
23
23
24
24
<!--
25
25
Please explain more context in this section, clarify why the changes are needed.
@@ -30,7 +30,7 @@ e.g:
30
30
31
31
## Main Changes
32
32
33
-
<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
33
+
<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better and faster reviews.)
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+13-11
Original file line number
Diff line number
Diff line change
@@ -1,7 +1,9 @@
1
1
# How to Contribute to HugeGraph
2
2
3
-
Thanks for taking the time to contribute! As an open source project, HugeGraph is looking forward to be contributed from everyone,
4
-
and we are also grateful to all the contributors.
3
+
> Refer [website-doc](https://hugegraph.apache.org/docs/contribution-guidelines/) for the latest information.
4
+
5
+
Thanks for taking the time to contribute!
6
+
As an open source project, HugeGraph is looking forward to being contributed from everyone, and we are also grateful to all the contributors.
5
7
6
8
The following is a contribution guide for HugeGraph:
7
9
@@ -15,7 +17,7 @@ We can contribute by reporting issues, submitting code patches or any other feed
15
17
16
18
Before submitting the code, we need to do some preparation:
17
19
18
-
1. Sign up or login to GitHub: [https://github.com](https://github.com)
20
+
1. Sign up or login to GitHub: [https://github.com](https://github.com)
19
21
20
22
2. Fork HugeGraph repo from GitHub: [https://github.com/apache/incubator-hugegraph/fork](https://github.com/apache/incubator-hugegraph/fork)
21
23
@@ -69,21 +71,21 @@ vim hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/HugeFacto
69
71
# run test locally (optional)
70
72
mvn test -Pcore-test,memory
71
73
```
72
-
Note: In order to be consistent with the code style easily, if you use [IDEA](https://www.jetbrains.com/idea/) as your IDE, you can directly [import](https://www.jetbrains.com/help/idea/configuring-code-style.html) our code style [configuration file](./hugegraph-style.xml).
74
+
Note: To be consistent with the code style easily, if you use [IDEA](https://www.jetbrains.com/idea/) as your IDE, you can directly [import](https://www.jetbrains.com/help/idea/configuring-code-style.html) our code style [configuration file](./hugegraph-style.xml).
73
75
74
76
##### 3.2.1 Check licenses
75
77
If we want to add new third-party dependencies to the `HugeGraph` project, we need to do the following things:
76
78
1. Find the third-party dependent repository, put the dependent `license` file into [./hugegraph-dist/release-docs/licenses/](https://github.com/apache/incubator-hugegraph/tree/master/hugegraph-dist/release-docs/licenses) path.
77
79
2. Declare the dependency in [./hugegraph-server/hugegraph-dist/release-docs/LICENSE](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/release-docs/LICENSE)`LICENSE` information.
78
80
3. Find the NOTICE file in the repository and append it to [./hugegraph-server/hugegraph-dist/release-docs/NOTICE](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/release-docs/NOTICE) file (skip this step if there is no NOTICE file).
79
-
4. Execute locally [./hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh) to update the dependency list [known-dependencies.txt](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/scripts/dependency/known-dependencies.txt) (or manually update).
81
+
4. Execute locally [./hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/scripts/dependency/regenerate_known_dependencies.sh) to update the dependency list [known-dependencies.txt](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-server/hugegraph-dist/scripts/dependency/known-dependencies.txt) (or manually update).
80
82
81
83
**Example**: A new third-party dependency is introduced into the project -> `ant-1.9.1.jar`
82
84
- The project source code is located at: https://github.com/apache/ant/tree/rel/1.9.1
The license information of `ant-1.9.1.jar` needs to be specified in the LICENSE file, and the notice information needs to be specified in the NOTICE file. The detailed LICENSE file corresponding to ant-1.9.1.jar needs to be copied to our licenses/ directory. Finally update the known-dependencies.txt file.
88
+
The license information of `ant-1.9.1.jar` needs to be specified in the LICENSE file, and the notice information needs to be specified in the NOTICE file. The detailed LICENSE file corresponding to ant-1.9.1.jar needs to be copied to our licenses/ directory. Finally, update the known-dependencies.txt file.
87
89
88
90
#### 3.3 Commit changes to git repo
89
91
@@ -105,7 +107,7 @@ Fix bug: run deploy multiple times
105
107
fix #ISSUE_ID
106
108
```
107
109
108
-
> Please remember to fill in the issue id, which was generated by GitHub after issue creation.
110
+
> Please remember to fill in the issue id, which GitHub generated after issue creation.
109
111
110
112
#### 3.4 Push commit to GitHub fork repo
111
113
@@ -121,7 +123,7 @@ Note that since GitHub requires submitting code through `username + token` (inst
121
123
122
124
## 4. Create a Pull Request
123
125
124
-
Go to the web page of GitHub fork repo, there would be a chance to create a Pull Request after pushing to a new branch, just click button "Compare & pull request" to do it. Then edit the description for proposed changes, which can just be copied from the commit message.
126
+
Go to the web page of GitHub fork repo, there would be a chance to create a Pull Request after pushing to a new branch, click the button "Compare & pull request" to do it. Then edit the description for proposed changes, which can just be copied from the commit message.
125
127
126
128
Note: please make sure the email address you used to submit the code is bound to the GitHub account. For how to bind the email address, please refer to https://github.com/settings/emails:
@@ -131,7 +133,7 @@ Note: please make sure the email address you used to submit the code is bound to
131
133
Maintainers will start the code review after all the **automatic** checks are passed:
132
134
133
135
- Check: Contributor License Agreement is signed
134
-
- Check: Travis CI builds is passed (automatically Test and Deploy)
136
+
- Check: Travis CI builds are passed (automatically Test and Deploy)
135
137
136
138
The commit will be accepted and merged if there is no problem after review.
137
139
@@ -171,8 +173,8 @@ And push it to GitHub fork repo again:
171
173
git push -f origin bugfix-branch:bugfix-branch
172
174
```
173
175
174
-
GitHub will automatically update the Pull Request after we push it, just wait for code review.
176
+
GitHub will automatically update the Pull Request after we push it, wait for code review.
175
177
176
-
Any question please contact to us through [hugegraph@googlegroups.com](mailto:hugegraph@googlegroups.com) or [other contact information](https://hugegraph.github.io/hugegraph-doc/).
178
+
For Any question, please contact us through [dev@hugegraph.apache.org](mailto:dev@hugegraph.apache.org) ([subscriber](https://hugegraph.apache.org/docs/contribution-guidelines/subscribe/) only)
0 commit comments