Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE][umbrella] Configuration enhancements #8326

Open
6 of 7 tasks
yikf opened this issue Dec 24, 2024 · 3 comments
Open
6 of 7 tasks

[CORE][umbrella] Configuration enhancements #8326

yikf opened this issue Dec 24, 2024 · 3 comments
Labels
enhancement New feature or request tracker Tracker of issues in the same category

Comments

@yikf
Copy link
Contributor

yikf commented Dec 24, 2024

Description

As discussed in #6970, we plan to enhance the gluten configuration, and the specific enhancement solutions can be found in section #6970 (comment).

This issue serves as an umbrella to record the task list that we need to include to achieve our goals, because enhance config involves a large number of files, splitting multiple tasks facilitates code review and reduces the risk of introducing other problems.

  1. [CORE] Introduce the ConfigEntry to make the config definition more flexible #8327 This task involves a large number of files. Due to the performance regressions of the CH backend, we refined this task into three parts:
  1. [CORE] Split the configuration into individual modules that belong to each other. #8479
  1. Split static config into independent file.
  1. Standardize configuration naming, log the deprecated config name if used.
  2. [CORE] Support generate configurations golden file and check it  #8070
@baibaichen
Copy link
Contributor

baibaichen commented Jan 7, 2025

@yikf as discussed in the offline, there are 2 requirement

  1. Pass spark config to backend. For example, ch backend need spark.sql.caseSensitive to choose compare behavior.
  2. Pass value type to backend. currently we use ConfigMap which assum value is string type.

@FelixYBW
Copy link
Contributor

@yikf Is the enhancement finished? Is there a readme about how to add a configuration?

@yikf
Copy link
Contributor Author

yikf commented Feb 19, 2025

@yikf Is the enhancement finished? Is there a readme about how to add a configuration?

It's not completed yet. I will keep following up in the next few days.

Eventually, there will be a configuration.md file to describe the configuration. Regarding the description of how to add the configuration, I can add it in this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracker Tracker of issues in the same category
Projects
None yet
Development

No branches or pull requests

3 participants