Skip to content

Commit e009208

Browse files
authored
[VL] Enable make_date function (#8683)
1 parent 9d23b46 commit e009208

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ object CHExpressionUtil {
204204
FROM_UTC_TIMESTAMP -> UtcTimestampValidator(),
205205
STACK -> DefaultValidator(),
206206
RAISE_ERROR -> DefaultValidator(),
207-
WIDTH_BUCKET -> DefaultValidator()
207+
WIDTH_BUCKET -> DefaultValidator(),
208+
MAKE_DATE -> DefaultValidator()
208209
)
209210
}

backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala

+7
Original file line numberDiff line numberDiff line change
@@ -1530,4 +1530,11 @@ abstract class ScalarFunctionsValidateSuite extends FunctionsValidateSuite {
15301530
}
15311531
}
15321532
}
1533+
1534+
test("make_date") {
1535+
runQueryAndCompare(
1536+
"select make_date(2025, 2, 7), make_date(2024, 11, null), make_date(2024, 11, 50)") {
1537+
checkGlutenOperatorMatch[ProjectExecTransformer]
1538+
}
1539+
}
15331540
}

gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala

+1
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ object ExpressionMappings {
192192
Sig[MonthsBetween](MONTHS_BETWEEN),
193193
Sig[DateFromUnixDate](DATE_FROM_UNIX_DATE),
194194
Sig[UnixDate](UNIX_DATE),
195+
Sig[MakeDate](MAKE_DATE),
195196
Sig[MakeTimestamp](MAKE_TIMESTAMP),
196197
Sig[MakeYMInterval](MAKE_YM_INTERVAL),
197198
Sig[ToUTCTimestamp](TO_UTC_TIMESTAMP),

shims/common/src/main/scala/org/apache/gluten/expression/ExpressionNames.scala

+1
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ object ExpressionNames {
217217
final val MONTHS_BETWEEN = "months_between"
218218
final val DATE_FROM_UNIX_DATE = "date_from_unix_date"
219219
final val UNIX_DATE = "unix_date"
220+
final val MAKE_DATE = "make_date"
220221
final val MAKE_TIMESTAMP = "make_timestamp"
221222
final val MAKE_YM_INTERVAL = "make_ym_interval"
222223
final val TO_UTC_TIMESTAMP = "to_utc_timestamp"

0 commit comments

Comments
 (0)