[GLUTEN-8894][VL] Fix buffer overflow in jStringToCString on arm (#8895)

kevinw66 · web-flow · commit 26f025f82ee5 · 2025-03-04T15:11:48.000Z
diff --git a/cpp/core/jni/JniCommon.h b/cpp/core/jni/JniCommon.h
@@ -39,7 +39,7 @@ static inline std::string jStringToCString(JNIEnv* env, jstring string) {
   int32_t jlen, clen;
   clen = env->GetStringUTFLength(string);
   jlen = env->GetStringLength(string);
-  char buffer[clen];
+  char buffer[clen + 1];
   env->GetStringUTFRegion(string, 0, jlen, buffer);
   return std::string(buffer, clen);
 }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ static inline std::string jStringToCString(JNIEnv* env, jstring string) {`
`39`	`39`	`int32_t jlen, clen;`
`40`	`40`	`clen = env->GetStringUTFLength(string);`
`41`	`41`	`jlen = env->GetStringLength(string);`
`42`		`- char buffer[clen];`
	`42`	`+ char buffer[clen + 1];`
`43`	`43`	`env->GetStringUTFRegion(string, 0, jlen, buffer);`
`44`	`44`	`return std::string(buffer, clen);`
`45`	`45`	`}`