Skip to content

Commit 04be9f4

Browse files
committed
fix clickhouse ci
1 parent f4f2e6c commit 04be9f4

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,6 @@ object VeloxBackendSettings extends BackendSettingsApi {
556556

557557
override def supportCartesianProductExec(): Boolean = true
558558

559-
override def supportBroadcastNestedLoopJoinExec(): Boolean = true
560-
561559
override def supportSampleExec(): Boolean = true
562560

563561
override def supportColumnarArrowUdf(): Boolean = true
@@ -566,4 +564,6 @@ object VeloxBackendSettings extends BackendSettingsApi {
566564

567565
override def supportCollectLimitExec(): Boolean = true
568566

567+
override def broadcastNestedLoopJoinSupportsFullOuterJoin(): Boolean = true
568+
569569
}

gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/BackendSettingsApi.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,6 @@ trait BackendSettingsApi {
145145

146146
def supportCartesianProductExecWithCondition(): Boolean = true
147147

148-
def supportBroadcastNestedLoopJoinExec(): Boolean = true
149-
150148
def supportSampleExec(): Boolean = false
151149

152150
def supportColumnarArrowUdf(): Boolean = false
@@ -155,4 +153,6 @@ trait BackendSettingsApi {
155153

156154
def supportCollectLimitExec(): Boolean = false
157155

156+
def broadcastNestedLoopJoinSupportsFullOuterJoin(): Boolean = false
157+
158158
}

gluten-substrait/src/main/scala/org/apache/gluten/execution/BroadcastNestedLoopJoinExecTransformer.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,8 @@ abstract class BroadcastNestedLoopJoinExecTransformer(
169169
def validateJoinTypeAndBuildSide(): ValidationResult = {
170170
val result = joinType match {
171171
case _: InnerLike | LeftOuter | RightOuter => ValidationResult.succeeded
172-
case FullOuter =>
172+
case FullOuter
173+
if BackendsApiManager.getSettings.broadcastNestedLoopJoinSupportsFullOuterJoin() =>
173174
if (condition.isEmpty) {
174175
ValidationResult.succeeded
175176
} else {

0 commit comments

Comments
 (0)