Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObjectStore::list_opts #7239

Open
tustvold opened this issue Mar 5, 2025 · 0 comments
Open

Add ObjectStore::list_opts #7239

tustvold opened this issue Mar 5, 2025 · 0 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 5, 2025

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We should add an ObjectStore::list_opts to allow

Describe the solution you'd like

I think the following API should work and eventually allow providing default implementations of list and list_with_delimiter that call through to list_opts

struct ListOptions {
    pub offset: Option<Path>,
    pub delimiter: bool,
    pub extensions: Extensions
}

fn list_opts(&self, opts: ListOptions) -> BoxStream<'static, Result<ListResult>>

Describe alternatives you've considered

We could expose an API that more explicitly exposes the paginated nature of the underlying APIs, however, such APIs are quite cumbersome to use, and wouldn't obviously translate to LocalFileSystem.

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

1 participant