New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/adbc/driver/snowflake: quote/escape names in ingestion #1064

Closed

Tracked by

lidavidm opened this issue Sep 14, 2023 · 1 comment

Closed

Tracked by

go/adbc/driver/snowflake: quote/escape names in ingestion #1064

lidavidm opened this issue Sep 14, 2023 · 1 comment

Milestone

ADBC Libraries 12

Member

lidavidm commented Sep 14, 2023

We currently quote column names and don't do anything with table names, but this is wrong in two ways:

We're using Go string literal quoting, which isn't correct; we should double-quote and escape quotes by doubling up quotes
We should quote table names, too.

A quick search didn't turn up anything in Gosnowflake to handle this so we'd have to do it ourselves.

lidavidm mentioned this issue

feat: 1.0.0 libraries release (tracking issue) #1490

Closed

26 tasks

lidavidm added this to the ADBC Libraries 1.0.0 milestone

Member Author

lidavidm commented Apr 29, 2024

This got covered by #1738

lidavidm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment