Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hinting with Upgraded OpenAPI #123

Open
andyliu14 opened this issue Dec 16, 2024 · 2 comments
Open

Add Type Hinting with Upgraded OpenAPI #123

andyliu14 opened this issue Dec 16, 2024 · 2 comments

Comments

@andyliu14
Copy link

kubernetes-client/python#1984

See related issue on Kubernetes. It looks like modern versions of openapi generator can generate api objects with type hinting baked in for much easier QOL for devs. This would be great to have to bump up the version of the generator to latest and regenerate.

@potiuk potiuk added the good first issue Good for newcomers label Dec 16, 2024
@pierrejeambrun
Copy link
Member

That's has been considered for a while but new versions of the generator are breaking and not backward compatible in terms of generated client. This is mainly the reason why we never upgraded it past a certain point.

We are preparing airflow 3 (Q1 / Q2 of 2025) and this will be upgraded then I believe.

@potiuk potiuk removed the good first issue Good for newcomers label Dec 16, 2024
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Dec 16, 2024

People can definitely start working on that preparing for airflow 3 using the new FastAPI API that we are developing for airflow 3.

On main, the openapi spec file is https://github.com/apache/airflow/blob/main/airflow/api_fastapi/core_api/openapi/v1-generated.yaml.

And we should start playing around to see what type of client is generated with an updated generator and if it works well with our spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants