simplified checks for compactors ZK locks and scan servers ZK locks

Author: kevinrr888

server/base/src/main/java/org/apache/accumulo/server/util/checkCommand/SystemConfigCheckRunner.java

@@ -68,9 +68,6 @@ private static Admin.CheckCommand.CheckStatus checkZKLocks(ServerContext context
     final ServerProcess[] serverProcesses = ServerProcess.values();
     final String zkRoot = context.getZooKeeperRoot();
     final var zs = context.getZooSession();
-    final var zrw = zs.asReaderWriter();
-    final var compactors = context.instanceOperations().getCompactors();
-    final var sservers = context.instanceOperations().getScanServers();
 
     log.trace("Checking ZooKeeper locks for Accumulo server processes...");
 
@@ -102,43 +99,21 @@ private static Admin.CheckCommand.CheckStatus checkZKLocks(ServerContext context
           break;
         case COMPACTOR:
           // nonessential process(es)
+          final var compactors = context.instanceOperations().getCompactors();
           if (compactors.isEmpty()) {
             log.debug("No compactors appear to be running... This may or may not be expected");
           }
-          for (String compactor : compactors) {
-            // for each running compactor, ensure a zk lock exists for it
-            boolean checkedLock = false;
-            String compactorQueuesPath = zkRoot + Constants.ZCOMPACTORS;
-            var compactorQueues = zrw.getChildren(compactorQueuesPath);
-            // find the queue the compactor is in
-            for (var queue : compactorQueues) {
-              String compactorQueuePath = compactorQueuesPath + "/" + queue;
-              String lockPath = compactorQueuePath + "/" + compactor;
-              if (zrw.exists(lockPath)) {
-                status = checkLock(lockPath, proc, true, zs, status);
-                checkedLock = true;
-                break;
-              }
-            }
-            if (!checkedLock) {
-              log.warn("Did not find a ZooKeeper lock for the compactor {}!", compactor);
-              status = Admin.CheckCommand.CheckStatus.FAILED;
-            }
-          }
           break;
         case MONITOR:
           // nonessential process
           status = checkLock(zkRoot + Constants.ZMONITOR_LOCK, proc, false, zs, status);
           break;
         case SCAN_SERVER:
           // nonessential process(es)
+          final var sservers = context.instanceOperations().getScanServers();
           if (sservers.isEmpty()) {
             log.debug("No scan servers appear to be running... This may or may not be expected");
           }
-          for (String sserver : sservers) {
-            status =
-                checkLock(zkRoot + Constants.ZSSERVERS + "/" + sserver, proc, true, zs, status);
-          }
           break;
         default:
           throw new IllegalStateException("Unhandled case: " + proc);