Skip to content

Commit 0cb4b41

Browse files
authored
Don't leak the file descriptors of companion ptys (#93)
1 parent 8b6b0ee commit 0cb4b41

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

docs/src/changelog.md

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@
1212

1313
### Security
1414

15+
## [`v0.3.4` (2022-10-13)](https://github.com/anupli/running-ng/releases/tag/v0.3.4)
16+
### Fixed
17+
#### Commands
18+
- `runbms`: fix the file descriptor leak when running benchmarks with companion programs.
19+
1520
## [`v0.3.3` (2022-10-12)](https://github.com/anupli/running-ng/releases/tag/v0.3.3)
1621
### Changed
1722
#### Commands

src/running/__version__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
VERSION = (0, 3, 3)
1+
VERSION = (0, 3, 4)
22
__VERSION__ = '.'.join(map(str, VERSION))

src/running/benchmark.py

+1
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ def run(self, runtime: Runtime, cwd: Path = None) -> Tuple[bytes, bytes, Subproc
137137
if exitcode != 0:
138138
raise subprocess.SubprocessError(
139139
"Exit code {} for the companion process".format(exitcode))
140+
os.close(fd)
140141
return stdout, companion_out, subprocess_exit
141142

142143

0 commit comments

Comments
 (0)