recursive flag doesn't show/apply changes when changed in community.vmware.vmware_object_role_permission

[willt]

SUMMARY

for the community.vmware.vmware_object_role_permission module
setting recursive from false to true or true to false does not show a change

So if at first I run this it sets recursive to false

- name:  Datastore permissions for metaswitch
  community.vmware.vmware_object_role_permission:
    hostname: "{{ vcenter_hostname }}"
    username: "{{ vcenter_username }}"
    password: "{{ vcenter_password }}"
    validate_certs: false
    role: Admin
    principal: "VSPHERE.LOCAL\\bob"
    object_type: Datastore
    object_name: my-datastore
    recursive: false
    state: present
  delegate_to: localhost

but then If I change it to this and rerun it doesn't make any changes

- name:  Datastore permissions for metaswitch
  community.vmware.vmware_object_role_permission:
    hostname: "{{ vcenter_hostname }}"
    username: "{{ vcenter_username }}"
    password: "{{ vcenter_password }}"
    validate_certs: false
    role: Admin
    principal: "VSPHERE.LOCAL\\bob"
    object_type: Datastore
    object_name: my-datastore
    recursive: true
    state: present
  delegate_to: localhost

[ihumster]

Nope, the module is written in such a way that if permission is assigned its compliance with the declaration is not checked. Need rework.

As a workaround, I can only offer to do Absent/Present.

[mariolenz]

I'm not sure, but it might work if we simply match propagate of Permission with recursive here:

community.vmware/plugins/modules/vmware_object_role_permission.py

Lines 219 to 221 in 09c21d5

	def same_permission(self, perm_one, perm_two):
	return perm_one.principal.lower() == perm_two.principal.lower() \
	and perm_one.roleId == perm_two.roleId

Might be worth a try.