Skip to content

Commit d14eb30

Browse files
authored
Module util vmware_rest_client: Remove get_tag_by_category (#1899)
Module util vmware_rest_client: Remove get_tag_by_category SUMMARY Fixes: #1898 Remove get_tag_by_category(). It's deprecated and not used anymore in the collection. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_rest_client ADDITIONAL INFORMATION #1605
1 parent 35d1674 commit d14eb30

File tree

2 files changed

+2
-33
lines changed

2 files changed

+2
-33
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
breaking_changes:
2+
- vmware_rest_client - Remove deprecated method `get_tag_by_category()` (https://github.com/ansible-collections/community.vmware/issues/1898).

plugins/module_utils/vmware_rest_client.py

-33
Original file line numberDiff line numberDiff line change
@@ -539,36 +539,3 @@ def get_tag_by_category_name(self, tag_name=None, category_name=None):
539539
category_id = category_obj.id
540540

541541
return self.get_tag_by_category_id(tag_name=tag_name, category_id=category_id)
542-
543-
def get_tag_by_category(self, tag_name=None, category_name=None, category_id=None):
544-
"""
545-
Return tag object by name and category name specified
546-
Args:
547-
tag_name: Name of tag
548-
category_name: Name of category (mutually exclusive with 'category_id')
549-
category_id: Id of category, if known in advance (mutually exclusive with 'category_name')
550-
Returns: Tag object if found else None
551-
"""
552-
message = "The method 'get_tag_by_category' is deprecated and scheduled for removal. "\
553-
"Please update your code and use 'get_tag_by_category_id' or 'get_tag_by_category_name' instead"
554-
self.module.deprecate(message, version='4.0.0', collection_name='community.vmware')
555-
556-
if not tag_name:
557-
return None
558-
559-
if category_id or category_name:
560-
if not category_id:
561-
category_obj = self.get_category_by_name(category_name=category_name)
562-
563-
if not category_obj:
564-
return None
565-
566-
category_id = category_obj.id
567-
568-
for tag_object in self.api_client.tagging.Tag.list_tags_for_category(category_id):
569-
tag_obj = self.api_client.tagging.Tag.get(tag_object)
570-
571-
if tag_obj.name == tag_name:
572-
return tag_obj
573-
else:
574-
return self.search_svc_object_by_name(service=self.api_client.tagging.Tag, svc_obj_name=tag_name)

0 commit comments

Comments
 (0)