Skip to content

Commit 13bfb11

Browse files
author
nina.loser
committed
Remove Folder and Datacenter because it's not used in this code
1 parent aacf239 commit 13bfb11

File tree

1 file changed

+0
-49
lines changed

1 file changed

+0
-49
lines changed

plugins/modules/vmware_guest_snapshot.py

-49
Original file line numberDiff line numberDiff line change
@@ -60,27 +60,6 @@
6060
- Whether to use the VMware instance UUID rather than the BIOS UUID.
6161
default: false
6262
type: bool
63-
folder:
64-
description:
65-
- Destination folder, absolute or relative path to find an existing guest.
66-
- This is required parameter, if O(name) is supplied.
67-
- The folder should include the datacenter. ESX's datacenter is ha-datacenter.
68-
- 'Examples:'
69-
- ' folder: /ha-datacenter/vm'
70-
- ' folder: ha-datacenter/vm'
71-
- ' folder: /datacenter1/vm'
72-
- ' folder: datacenter1/vm'
73-
- ' folder: /datacenter1/vm/folder1'
74-
- ' folder: datacenter1/vm/folder1'
75-
- ' folder: /folder1/datacenter1/vm'
76-
- ' folder: folder1/datacenter1/vm'
77-
- ' folder: /folder1/datacenter1/vm/folder2'
78-
type: str
79-
datacenter:
80-
description:
81-
- Destination datacenter for the deploy operation.
82-
required: true
83-
type: str
8463
snapshot_name:
8564
description:
8665
- Sets the snapshot name to manage.
@@ -139,8 +118,6 @@
139118
hostname: "{{ vcenter_hostname }}"
140119
username: "{{ vcenter_username }}"
141120
password: "{{ vcenter_password }}"
142-
datacenter: "{{ datacenter_name }}"
143-
folder: "/{{ datacenter_name }}/vm/"
144121
name: "{{ guest_name }}"
145122
state: present
146123
snapshot_name: snap1
@@ -152,8 +129,6 @@
152129
hostname: "{{ vcenter_hostname }}"
153130
username: "{{ vcenter_username }}"
154131
password: "{{ vcenter_password }}"
155-
datacenter: "{{ datacenter_name }}"
156-
folder: "/{{ datacenter_name }}/vm/"
157132
name: "{{ guest_name }}"
158133
state: absent
159134
snapshot_name: snap1
@@ -164,8 +139,6 @@
164139
hostname: "{{ vcenter_hostname }}"
165140
username: "{{ vcenter_username }}"
166141
password: "{{ vcenter_password }}"
167-
datacenter: "{{ datacenter_name }}"
168-
folder: "/{{ datacenter_name }}/vm/"
169142
name: "{{ guest_name }}"
170143
state: revert
171144
snapshot_name: snap1
@@ -176,8 +149,6 @@
176149
hostname: "{{ vcenter_hostname }}"
177150
username: "{{ vcenter_username }}"
178151
password: "{{ vcenter_password }}"
179-
datacenter: "{{ datacenter_name }}"
180-
folder: "/{{ datacenter_name }}/vm/"
181152
name: "{{ guest_name }}"
182153
state: remove_all
183154
delegate_to: localhost
@@ -187,8 +158,6 @@
187158
hostname: "{{ vcenter_hostname }}"
188159
username: "{{ vcenter_username }}"
189160
password: "{{ vcenter_password }}"
190-
datacenter: "{{ datacenter_name }}"
191-
folder: "/{{ datacenter_name }}/vm/"
192161
moid: vm-42
193162
state: remove_all
194163
delegate_to: localhost
@@ -198,8 +167,6 @@
198167
hostname: "{{ vcenter_hostname }}"
199168
username: "{{ vcenter_username }}"
200169
password: "{{ vcenter_password }}"
201-
datacenter: "{{ datacenter_name }}"
202-
folder: "/{{ datacenter_name }}/vm/"
203170
name: "{{ guest_name }}"
204171
state: present
205172
snapshot_name: dummy_vm_snap_0001
@@ -212,8 +179,6 @@
212179
hostname: "{{ vcenter_hostname }}"
213180
username: "{{ vcenter_username }}"
214181
password: "{{ vcenter_password }}"
215-
datacenter: "{{ datacenter_name }}"
216-
folder: "/{{ datacenter_name }}/vm/"
217182
name: "{{ guest_name }}"
218183
state: absent
219184
remove_children: true
@@ -225,8 +190,6 @@
225190
hostname: "{{ vcenter_hostname }}"
226191
username: "{{ vcenter_username }}"
227192
password: "{{ vcenter_password }}"
228-
datacenter: "{{ datacenter_name }}"
229-
folder: "/{{ datacenter_name }}/vm/"
230193
name: "{{ guest_name }}"
231194
snapshot_id: 10
232195
state: absent
@@ -237,8 +200,6 @@
237200
hostname: "{{ vcenter_hostname }}"
238201
username: "{{ vcenter_username }}"
239202
password: "{{ vcenter_password }}"
240-
datacenter: "{{ datacenter_name }}"
241-
folder: "/{{ datacenter_name }}/vm/"
242203
name: "{{ guest_name }}"
243204
state: present
244205
snapshot_name: current_snap_name
@@ -444,8 +405,6 @@ def main():
444405
uuid=dict(type='str'),
445406
moid=dict(type='str'),
446407
use_instance_uuid=dict(type='bool', default=False),
447-
folder=dict(type='str'),
448-
datacenter=dict(required=True, type='str'),
449408
snapshot_name=dict(type='str'),
450409
snapshot_id=dict(type='int'),
451410
description=dict(type='str', default=''),
@@ -457,9 +416,6 @@ def main():
457416
)
458417
module = AnsibleModule(
459418
argument_spec=argument_spec,
460-
required_together=[
461-
['name', 'folder']
462-
],
463419
required_one_of=[
464420
['name', 'uuid', 'moid']
465421
],
@@ -468,11 +424,6 @@ def main():
468424
]
469425
)
470426

471-
if module.params['folder']:
472-
# FindByInventoryPath() does not require an absolute path
473-
# so we should leave the input folder path unmodified
474-
module.params['folder'] = module.params['folder'].rstrip('/')
475-
476427
pyv = PyVmomiHelper(module)
477428
# Check if the VM exists before continuing
478429
vm = pyv.get_vm()

0 commit comments

Comments
 (0)