Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gas fee calculation when missing estimations #1693

Open
euharrison opened this issue Feb 20, 2025 · 1 comment
Open

Improve gas fee calculation when missing estimations #1693

euharrison opened this issue Feb 20, 2025 · 1 comment

Comments

@euharrison
Copy link
Collaborator

In case the indexer do have estimations, we apply our math and it works fine

But in case the indexer don't have estimations (totalEstimations:0), it returns the default value, and, when we apply the math, it scales more on top of it

Example:

{
  "min": 22315,
  "max": 25090,
  "avg": 23408,
  "totalEstimates": 20
}
{
  "min": 100000,
  "max": 100000,
  "avg": 100000,
  "totalEstimates": 0
}

What we can do on Namadillo is apply a different scale factor based on the totalEstimates

@neocybereth
Copy link
Contributor

neocybereth commented Feb 20, 2025

Image

Here's a separate todo on this that may be worth doing at the same time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants