Skip to content

Commit 3bdcb64

Browse files
authored
Fix display of detector names (opensearch-project#585)
When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière <romain@blogreen.org>
1 parent 53677c5 commit 3bdcb64

File tree

1 file changed

+6
-6
lines changed
  • public/pages/DetectorsList/containers/ConfirmActionModals/utils

1 file changed

+6
-6
lines changed

public/pages/DetectorsList/containers/ConfirmActionModals/utils/helpers.tsx

+6-6
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const getNames = (detectors: DetectorListItem[]) => {
2727
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
2828
target="_blank"
2929
>
30-
{detectors[i].name} />
30+
{detectors[i].name}
3131
</EuiLink>
3232
),
3333
});
@@ -49,15 +49,15 @@ const getNamesAndMonitors = (
4949
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
5050
target="_blank"
5151
>
52-
{detectors[i].name} />
52+
{detectors[i].name}
5353
</EuiLink>
5454
),
5555
Monitor: (
5656
<EuiLink
5757
href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`}
5858
target="_blank"
5959
>
60-
{relatedMonitor.name} />
60+
{relatedMonitor.name}
6161
</EuiLink>
6262
),
6363
});
@@ -68,7 +68,7 @@ const getNamesAndMonitors = (
6868
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
6969
target="_blank"
7070
>
71-
{detectors[i].name} />
71+
{detectors[i].name}
7272
</EuiLink>
7373
),
7474
Monitor: '-',
@@ -95,15 +95,15 @@ const getNamesAndMonitorsAndStates = (
9595
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
9696
target="_blank"
9797
>
98-
{detectors[i].name} />
98+
{detectors[i].name}
9999
</EuiLink>
100100
),
101101
Monitor: (
102102
<EuiLink
103103
href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`}
104104
target="_blank"
105105
>
106-
{relatedMonitor.name} />
106+
{relatedMonitor.name}
107107
</EuiLink>
108108
),
109109
Running: <EuiText>{isRunning ? 'Yes' : 'No'}</EuiText>,

0 commit comments

Comments
 (0)