Skip to content

Commit 54b3f85

Browse files
f1337LindseySaari
andauthored
fix: update thor dependency (pact-foundation#124)
Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io> Co-authored-by: Lindsey Hattamer <lindsey.hattamer@oddball.io>
1 parent 0e7bc86 commit 54b3f85

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

lib/pact/mock_service/cli.rb

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
module Pact
1010
module MockService
1111
class CLI < Thor
12+
def self.exit_on_failure? # Thor 1.0 deprecation guard
13+
false
14+
end
1215

1316
PACT_FILE_WRITE_MODE_DESC = "`overwrite` or `merge`. Use `merge` when running multiple mock service instances in parallel for the same consumer/provider pair." +
1417
" Ensure the pact file is deleted before running tests when using this option so that interactions deleted from the code are not maintained in the file."

lib/pact/mock_service/cli/custom_thor.rb

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ class CLI < Thor
1111
# `script --help` to display the help for the default task instead of the command list
1212
#
1313
class CustomThor < ::Thor
14+
def self.exit_on_failure? # Thor 1.0 deprecation guard
15+
false
16+
end
1417

1518
no_commands do
1619
def self.start given_args = ARGV, config = {}

lib/pact/mock_service/cli/pidfile.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
module Pact
44
module MockService
55
class CLI < Thor
6+
def self.exit_on_failure? # Thor 1.0 deprecation guard
7+
false
8+
end
69

710
class Pidfile
8-
911
attr_accessor :pid_dir, :name, :pid
1012

1113
def initialize options

pact-mock_service.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Gem::Specification.new do |gem|
2323
gem.add_runtime_dependency 'rack', '~> 2.0'
2424
gem.add_runtime_dependency 'rspec', '>=2.14'
2525
gem.add_runtime_dependency 'find_a_port', '~> 1.0.1'
26-
gem.add_runtime_dependency 'thor', '~> 0.19'
26+
gem.add_runtime_dependency 'thor', '>= 0.19', '< 2.0'
2727
gem.add_runtime_dependency 'json'
2828
gem.add_runtime_dependency 'webrick', '~> 1.3'
2929
gem.add_runtime_dependency 'term-ansicolor', '~> 1.0'

0 commit comments

Comments
 (0)