From 59d6e2f8cdadb965703498e289a86e9fb997ab4a Mon Sep 17 00:00:00 2001 From: "radoslaw.chrzanowski" Date: Mon, 10 Mar 2025 08:08:04 +0100 Subject: [PATCH] fix typos --- CHANGELOG.md | 2 +- .../envoycontrol/groups/RoutesAssertions.kt | 2 +- .../routes/EnvoyIngressRoutesFactoryTest.kt | 18 +++++++++--------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f56f4dfe1..d04ddeb29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ## [0.22.11] ### Changed -- white list for enabling separated routes for status endpoints +- whitelist for enabling separated routes for status endpoints ## [0.22.10] ### Changed diff --git a/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/RoutesAssertions.kt b/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/RoutesAssertions.kt index fcf537ba8..08c0c7c27 100644 --- a/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/RoutesAssertions.kt +++ b/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/RoutesAssertions.kt @@ -240,7 +240,7 @@ fun Route.ingressServiceRoute() { .toCluster("local_service") } -fun Route.ingresStatusRoute() { +fun Route.ingressStatusRoute() { this.matchingOnPrefix("/status/") .publicAccess() .toCluster("local_service") diff --git a/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt b/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt index 43849e38c..f51265cf8 100644 --- a/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt +++ b/envoy-control-core/src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/routes/EnvoyIngressRoutesFactoryTest.kt @@ -29,8 +29,8 @@ import pl.allegro.tech.servicemesh.envoycontrol.groups.hasRequestHeadersToRemove import pl.allegro.tech.servicemesh.envoycontrol.groups.hasResponseHeaderToAdd import pl.allegro.tech.servicemesh.envoycontrol.groups.hasSingleVirtualHostThat import pl.allegro.tech.servicemesh.envoycontrol.groups.hasStatusVirtualClusters -import pl.allegro.tech.servicemesh.envoycontrol.groups.ingresStatusRoute import pl.allegro.tech.servicemesh.envoycontrol.groups.ingressServiceRoute +import pl.allegro.tech.servicemesh.envoycontrol.groups.ingressStatusRoute import pl.allegro.tech.servicemesh.envoycontrol.groups.matchingOnAnyMethod import pl.allegro.tech.servicemesh.envoycontrol.groups.matchingOnMethod import pl.allegro.tech.servicemesh.envoycontrol.groups.matchingOnPrefix @@ -175,17 +175,17 @@ internal class EnvoyIngressRoutesFactoryTest { }, *adminRoutes, { - ingresStatusRoute() + ingressStatusRoute() matchingOnMethod("GET") matchingRetryPolicy(retryPolicyProps.perHttpMethod["GET"]!!) }, { - ingresStatusRoute() + ingressStatusRoute() matchingOnMethod("HEAD") matchingRetryPolicy(retryPolicyProps.perHttpMethod["HEAD"]!!) }, { - ingresStatusRoute() + ingressStatusRoute() matchingOnAnyMethod() hasNoRetryPolicy() }, @@ -233,7 +233,7 @@ internal class EnvoyIngressRoutesFactoryTest { @Test @Suppress("LongMethod") - fun `should create not create routes for status endpoints if the service is not whitelisted`() { + fun `should not create routes for status endpoints if the service is not whitelisted`() { // given val routesFactory = EnvoyIngressRoutesFactory(SnapshotProperties().apply { routes.status.apply { @@ -300,7 +300,7 @@ internal class EnvoyIngressRoutesFactoryTest { @Test @Suppress("LongMethod") - fun `should create create routes for status endpoints when whitelist contains wildcard`() { + fun `should create routes for status endpoints when whitelist contains wildcard`() { // given val routesFactory = EnvoyIngressRoutesFactory(SnapshotProperties().apply { routes.status.apply { @@ -346,17 +346,17 @@ internal class EnvoyIngressRoutesFactoryTest { hasOnlyRoutesInOrder( *adminRoutes, { - ingresStatusRoute() + ingressStatusRoute() matchingOnMethod("GET") matchingRetryPolicy(retryPolicyProps.perHttpMethod["GET"]!!) }, { - ingresStatusRoute() + ingressStatusRoute() matchingOnMethod("HEAD") matchingRetryPolicy(retryPolicyProps.perHttpMethod["HEAD"]!!) }, { - ingresStatusRoute() + ingressStatusRoute() matchingOnAnyMethod() hasNoRetryPolicy() },