sale_packaging_default: allow for less-than-packaging-quantity quantities on lines

Author: kevinkhao

sale_packaging_default/models/sale_order_line.py

@@ -1,8 +1,7 @@
 # Copyright 2023 Moduon Team S.L.
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl-3.0)
-from contextlib import suppress
 
-from odoo import api, fields, models
+from odoo import api, models
 
 
 class SaleOrderLine(models.Model):
@@ -19,37 +18,37 @@ def onchange(self, values, field_name, field_onchange):
         _self = self.with_context(changing_fields=names)
         return super(SaleOrderLine, _self).onchange(values, field_name, field_onchange)
 
-    @api.depends("product_id", "product_uom_qty", "product_uom")
-    def _compute_product_packaging_id(self):
-        """Set a default packaging for sales if possible."""
-        for line in self:
-            if line.product_id != line.product_packaging_id.product_id:
-                line.product_packaging_id = line._get_default_packaging(line.product_id)
-        result = super()._compute_product_packaging_id()
-        # If there's no way to package the desired qty, remove the packaging.
-        # It is only done when the user is currently manually setting
-        # `product_uom_qty` to zero. In other cases, we are maybe getting
-        # default values and this difference will get fixed by other compute
-        # methods later.
-        if (
-            self.env.context.get("changing_fields")
-            and "product_uom_qty" not in self.env.context["changing_fields"]
-        ):
-            return result
-        for line in self:
-            with suppress(ZeroDivisionError):
-                if (
-                    line.product_uom_qty
-                    and line.product_uom_qty % line.product_packaging_id.qty
-                ):
-                    line.product_packaging_id = False
-        return result
-
-    @api.model
-    def _get_default_packaging(self, product):
-        return fields.first(
-            product.packaging_ids.filtered_domain([("sales", "=", True)])
-        )
+    # @api.depends("product_id", "product_uom_qty", "product_uom")
+    # def _compute_product_packaging_id(self):
+    #     """Set a default packaging for sales if possible."""
+    #     for line in self:
+    #         if line.product_id != line.product_packaging_id.product_id:
+    #             line.product_packaging_id = line._get_default_packaging(line.product_id)
+    #     result = super()._compute_product_packaging_id()
+    #     # If there's no way to package the desired qty, remove the packaging.
+    #     # It is only done when the user is currently manually setting
+    #     # `product_uom_qty` to zero. In other cases, we are maybe getting
+    #     # default values and this difference will get fixed by other compute
+    #     # methods later.
+    #     if (
+    #         self.env.context.get("changing_fields")
+    #         and "product_uom_qty" not in self.env.context["changing_fields"]
+    #     ):
+    #         return result
+    #     for line in self:
+    #         with suppress(ZeroDivisionError):
+    #             if (
+    #                 line.product_uom_qty
+    #                 and line.product_uom_qty % line.product_packaging_id.qty
+    #             ):
+    #                 line.product_packaging_id = False
+    #     return result
+    #
+    # @api.model
+    # def _get_default_packaging(self, product):
+    #     return fields.first(
+    #         product.packaging_ids.filtered_domain([("sales", "=", True)])
+    #     )
 
     @api.depends("product_packaging_id", "product_uom", "product_uom_qty")
     def _compute_product_packaging_qty(self):

sale_packaging_default/tests/test_sale_packaging_default.py

@@ -81,11 +81,11 @@ def test_default_packaging_sale_order(self):
             line_f.product_uom_qty = 120
             self.assertEqual(line_f.product_packaging_qty, 10)
             self.assertEqual(line_f.product_packaging_id, self.dozen)
-            # If I set a uom qty without packaging, it is emptied
-            line_f.product_uom_qty = 7
-            self.assertFalse(line_f.product_packaging_id)
-            self.assertEqual(line_f.product_packaging_qty, 0)
-            self.assertEqual(line_f.product_uom_qty, 7)
+            # # If I set a uom qty without packaging, it is emptied
+            # line_f.product_uom_qty = 7
+            # self.assertFalse(line_f.product_packaging_id)
+            # self.assertEqual(line_f.product_packaging_qty, 0)
+            # self.assertEqual(line_f.product_uom_qty, 7)
             # Setting zero uom qty resets to the default packaging
             line_f.product_uom_qty = 0
             self.assertEqual(line_f.product_packaging_id, self.big_box)