[MIG] delivery_postlogistics: Migration to 14.0

The cassette `tests/fixtures/cassettes/test_store_label.yaml` should be
updated as the label was failed to decode in both 13.0 and 14.0.

* https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_attachment.py#L212
* https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L554

We can remove the method _selection_file_type with below reasons.

* It is used in base_delivery_carrier_label but was removed on Sep 5, 2019
  https://github.com/OCA/delivery-carrier/blame/12.0/base_delivery_carrier_label/models/shipping_label.py#L15
* PR migration to 13.0 of base_delivery_carrier_label was merged on Oct 22, 2020
  https://github.com/OCA/delivery-carrier/pull/251/files
* Dependency on base_delivery_carrier_label was removed in migration to 14.0 on Apr 14 2021
  OCA@4ba2b56#diff-f16078e35000c05a9b63f5e7e04b6f5fd50eadae8b14a45aa9c1eb078031060cL12 OCA@4ba2b56#diff-08c11b571d9c0b0c509c3922c77f407ef4c429473fda9bc2d4d542520e7a4e3fR12

Author: hailangvn

delivery_postlogistics/README.rst

@@ -14,13 +14,13 @@ PostLogistics Shipping - “Barcode” web service
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fdelivery--carrier-lightgray.png?logo=github
-    :target: https://github.com/OCA/delivery-carrier/tree/13.0/delivery_postlogistics
+    :target: https://github.com/OCA/delivery-carrier/tree/14.0/delivery_postlogistics
     :alt: OCA/delivery-carrier
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_postlogistics
+    :target: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_postlogistics
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/99/13.0
+    :target: https://runbot.odoo-community.org/runbot/99/14.0
     :alt: Try me on Runbot
 
 |badge1| |badge2| |badge3| |badge4| |badge5| 
@@ -83,7 +83,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/delivery-carrier/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/delivery-carrier/issues/new?body=module:%20delivery_postlogistics%0Aversion:%2013.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/delivery-carrier/issues/new?body=module:%20delivery_postlogistics%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -109,7 +109,7 @@ Contributors
 Other credits
 ~~~~~~~~~~~~~
 
-The development of this module has been financially supported by:
+The development of this module in version 13.0 and its migration from 13.0 to 14.0 has been financially supported by:
 
 * Camptocamp
 
@@ -126,6 +126,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/delivery-carrier <https://github.com/OCA/delivery-carrier/tree/13.0/delivery_postlogistics>`_ project on GitHub.
+This module is part of the `OCA/delivery-carrier <https://github.com/OCA/delivery-carrier/tree/14.0/delivery_postlogistics>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

delivery_postlogistics/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "PostLogistics Shipping - “Barcode” web service",
     "summary": "Print PostLogistics shipping labels using the Barcode web service",
-    "version": "13.0.1.2.0",
+    "version": "14.0.1.0.0",
     "author": "Camptocamp,Odoo Community Association (OCA)",
     "maintainer": "Camptocamp",
     "license": "AGPL-3",
@@ -12,6 +12,7 @@
     "depends": ["delivery", "mail", "base"],
     "website": "https://github.com/OCA/delivery-carrier",
     "data": [
+        "security/ir.model.access.csv",
         "data/partner.xml",
         "data/product.xml",
         "data/delivery.xml",
@@ -21,7 +22,6 @@
         "views/postlogistics_license.xml",
         "views/res_partner_view.xml",
         "views/stock.xml",
-        "security/ir.model.access.csv",
     ],
     "installable": True,
     "auto_install": False,

delivery_postlogistics/i18n/delivery_postlogistics.pot

@@ -4,8 +4,10 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 13.0\n"
+"Project-Id-Version: Odoo Server 14.0\n"
 "Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2021-06-21 02:01+0000\n"
+"PO-Revision-Date: 2021-06-21 02:01+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -186,9 +188,15 @@ msgid "Disabled"
 msgstr ""
 
 #. module: delivery_postlogistics
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_delivery_carrier__display_name
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_delivery_carrier_template_option__display_name
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_license__display_name
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label__display_name
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_product_packaging__display_name
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_res_partner__display_name
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_move__display_name
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_picking__display_name
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_quant_package__display_name
 msgid "Display Name"
 msgstr ""
 
@@ -226,7 +234,12 @@ msgstr ""
 
 #. module: delivery_postlogistics
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label__datas
-msgid "File Content"
+msgid "File Content (base64)"
+msgstr ""
+
+#. module: delivery_postlogistics
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label__raw
+msgid "File Content (raw)"
 msgstr ""
 
 #. module: delivery_postlogistics
@@ -293,9 +306,15 @@ msgid ""
 msgstr ""
 
 #. module: delivery_postlogistics
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_delivery_carrier__id
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_delivery_carrier_template_option__id
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_license__id
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label__id
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_product_packaging__id
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_res_partner__id
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_move__id
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_picking__id
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_quant_package__id
 msgid "ID"
 msgstr ""
 
@@ -347,9 +366,15 @@ msgid "Label layout"
 msgstr ""
 
 #. module: delivery_postlogistics
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_delivery_carrier____last_update
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_delivery_carrier_template_option____last_update
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_license____last_update
 #: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label____last_update
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_product_packaging____last_update
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_res_partner____last_update
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_move____last_update
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_picking____last_update
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_stock_quant_package____last_update
 msgid "Last Modified on"
 msgstr ""
 
@@ -441,6 +466,11 @@ msgid ""
 "We recommend using a black and white logo for printing in  the ZPL2 format."
 msgstr ""
 
+#. module: delivery_postlogistics
+#: model:ir.model.fields,field_description:delivery_postlogistics.field_postlogistics_shipping_label__original_id
+msgid "Original (unoptimized, unresized) attachment"
+msgstr ""
+
 #. module: delivery_postlogistics
 #: model:ir.model.fields.selection,name:delivery_postlogistics.selection__postlogistics_delivery_carrier_template_option__postlogistics_type__output_format
 msgid "Output Format"

delivery_postlogistics/models/delivery_carrier.py

@@ -4,19 +4,26 @@
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
 
+from ..postlogistics.web_service import PostlogisticsWebService
+
 
 class DeliveryCarrier(models.Model):
     """ Add service group """
 
     _inherit = "delivery.carrier"
 
-    delivery_type = fields.Selection(selection_add=[("postlogistics", "PostLogistics")])
+    delivery_type = fields.Selection(
+        selection_add=[("postlogistics", "PostLogistics")],
+        ondelete={"postlogistics": "set default"},
+    )
     postlogistics_default_packaging_id = fields.Many2one(
         "product.packaging", domain=[("package_carrier_type", "=", "postlogistics")]
     )
 
     postlogistics_endpoint_url = fields.Char(
-        string="Endpoint URL", default="https://wedecint.post.ch/", required=True,
+        string="Endpoint URL",
+        default="https://wedecint.post.ch/",
+        required=True,
     )
     postlogistics_client_id = fields.Char(
         string="Client ID", groups="base.group_system"
@@ -84,7 +91,8 @@ class DeliveryCarrier(models.Model):
     )
 
     postlogistics_license_id = fields.Many2one(
-        comodel_name="postlogistics.license", string="Franking License",
+        comodel_name="postlogistics.license",
+        string="Franking License",
     )
     zpl_patch_string = fields.Char(
         string="ZPL Patch String", default="^XA^CW0,E:TT0003M_.TTF^XZ^XA^CI28"
@@ -132,3 +140,19 @@ def postlogistics_send_shipping(self, pickings):
             pick._generate_postlogistics_label()
 
         return [{"exact_price": False, "tracking_number": False}]
+
+    def verify_credentials(self):
+        access_token = PostlogisticsWebService.get_access_token(self)
+        if not access_token:
+            # Error has already been risen
+            return
+        message = {
+            "type": "ir.actions.client",
+            "tag": "display_notification",
+            "params": {
+                "title": _("Validated"),
+                "message": _("The credential is valid."),
+                "sticky": False,
+            },
+        }
+        return message

delivery_postlogistics/models/postlogistics_carrier_template_options.py

@@ -27,5 +27,6 @@ class DeliveryCarrierTemplateOption(models.Model):
         help="Allow to define a more complete description than in the name field.",
     )
     postlogistics_type = fields.Selection(
-        selection=POSTLOGISTICS_TYPES, string="PostLogistics option type",
+        selection=POSTLOGISTICS_TYPES,
+        string="PostLogistics option type",
     )

delivery_postlogistics/models/postlogistics_shipping_label.py

@@ -1,7 +1,7 @@
 # Copyright 2013-2016 Camptocamp SA
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import fields, models
 
 
 class PostlogisticsShippingLabel(models.Model):
@@ -18,27 +18,3 @@ class PostlogisticsShippingLabel(models.Model):
         required=True,
         ondelete="cascade",
     )
-
-    # TODO: check if we can remove this method
-    @api.model
-    def _selection_file_type(self):
-        """ Return a concatenated list of extensions of label file format
-        plus file format from super
-
-        This will be filtered and sorted in __get_file_type_selection
-
-        :return: list of tuple (code, name)
-
-        """
-        file_types = super()._selection_file_type()
-        new_types = [
-            ("eps", "EPS"),
-            ("gif", "GIF"),
-            ("jpg", "JPG"),
-            ("png", "PNG"),
-            ("pdf", "PDF"),
-            ("spdf", "sPDF"),  # sPDF is a pdf without integrated font
-            ("zpl2", "ZPL2"),
-        ]
-        file_types.extend(new_types)
-        return file_types

delivery_postlogistics/models/stock_picking.py

@@ -73,17 +73,16 @@ def attach_shipping_label(self, label):
         )
 
     def _set_a_default_package(self):
-        """ Pickings using this module must have a package
-            If not this method put it one silently
+        """Pickings using this module must have a package
+        If not this method put it one silently
         """
         for picking in self:
             move_lines = picking.move_line_ids.filtered(
                 lambda s: not (s.package_id or s.result_package_id)
             )
             if move_lines:
-                default_packaging = (
-                    picking.carrier_id.postlogistics_default_packaging_id
-                )
+                carrier = picking.carrier_id
+                default_packaging = carrier.postlogistics_default_packaging_id
                 package = self.env["stock.quant.package"].create(
                     {
                         "packaging_id": default_packaging
@@ -94,7 +93,7 @@ def _set_a_default_package(self):
                 move_lines.write({"result_package_id": package.id})
 
     def postlogistics_cod_amount(self):
-        """ Return the PostLogistics Cash on Delivery amount of a picking
+        """Return the PostLogistics Cash on Delivery amount of a picking
 
         If the picking delivers the whole sales order, we use the total
         amount of the sales order.
@@ -115,10 +114,8 @@ def postlogistics_cod_amount(self):
                     "from different sales orders."
                 )
             )
-        order_moves = order.mapped("order_line.procurement_ids.move_ids")
-        picking_moves = self.move_lines
         # check if the package delivers the whole sales order
-        if order_moves != picking_moves:
+        if len(order.picking_ids) > 1:
             raise exceptions.Warning(
                 _(
                     "The cash on delivery amount must be manually specified "
@@ -228,7 +225,7 @@ def _generate_postlogistics_label(
         if failed_label_results:
             # Commit the change to save the changes,
             # This ensures the label pushed recored correctly in Odoo
-            self._cr.commit()
+            self._cr.commit()  # pylint: disable=invalid-commit
             error_message = "\n".join(label["errors"] for label in failed_label_results)
             raise exceptions.Warning(error_message)
         return labels

delivery_postlogistics/models/stock_quant_package.py

@@ -12,7 +12,10 @@ class StockQuantPackage(models.Model):
         "than the total of the sales order, write the amount there.",
     )
     parcel_tracking = fields.Char("Parcel Tracking")
-    package_carrier_type = fields.Selection(related="packaging_id.package_carrier_type")
+    package_carrier_type = fields.Selection(
+        related="packaging_id.package_carrier_type",
+        string="Packaging's Carrier",
+    )
 
     @api.returns("stock.picking")
     def _get_origin_pickings(self):
@@ -22,7 +25,7 @@ def _get_origin_pickings(self):
         return move_line.mapped("picking_id.sale_id.picking_ids")
 
     def postlogistics_cod_amount(self):
-        """ Return the PostLogistics Cash on Delivery amount of a package
+        """Return the PostLogistics Cash on Delivery amount of a package
 
         If we have only 1 package which delivers the whole sales order
         we use the total amount of the sales order.