-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incr/decr #432
base: master
Are you sure you want to change the base?
Fix incr/decr #432
Conversation
I'm pretty sure you're correct, but I'm a little confused with why codecov says the line is fully covered already: |
Not sure how codecov works but the line (L333) is covered and it's probably one statement even if some expressions are not visited. |
It has branch coverage, so if the condition was always True, then it'd be highlighted yellow to show the line only has partial coverage. That's the bit that confuses me. It's probably fine though, might just be a hiccup with the coverage tool. |
For anyone who needs this patch, use a fork |
What do these changes do?
Are there changes in behavior for the user?
Related issue number
#431
Checklist