Skip to content

Commit 94ff4d6

Browse files
ayalevin123shemminger
authored andcommitted
devlink: Fix inconsistency between command input and output
In devlink health show command the reporter's name parameter is called reporter, but in the output the reporter's name is referred to as name Before this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: name tx state healthy error 0 recover 0 grace_period 500 auto_recover true After this patch: $ devlink health show pci/0000:04:00.0 reporter tx pci/0000:04:00.0: reporter tx state healthy error 0 recover 0 grace_period 500 auto_recover true Reported-by: Jiri Pirko <jiri@mellanox.com> Fixes: 2f1242e ("devlink: Add devlink health show command") Signed-off-by: Aya Levin <ayal@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
1 parent 7dd3d51 commit 94ff4d6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

devlink/devlink.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -6660,7 +6660,7 @@ static void pr_out_health(struct dl *dl, struct nlattr **tb_health)
66606660

66616661
pr_out_handle_start_arr(dl, tb_health);
66626662

6663-
pr_out_str(dl, "name",
6663+
pr_out_str(dl, "reporter",
66646664
mnl_attr_get_str(tb[DEVLINK_ATTR_HEALTH_REPORTER_NAME]));
66656665
if (!dl->json_output) {
66666666
__pr_out_newline();

0 commit comments

Comments
 (0)