feat: reorg detector add warnings and store in DB the reorg detection #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
changed the title
|
| DROP TABLE IF EXISTS reorg_event; | ||
|
|
||
| -- +migrate Up | ||
| CREATE TABLE reorg_event ( |
There was a problem hiding this comment.
Do we need some primary key for the table?
| SubscriberID: id, | ||
| CurrentHash: currentHeader.Hash(), | ||
| TrackedHash: hdr.Hash, | ||
| ExtraData: struct { |
There was a problem hiding this comment.
What is the usage of ExtraData field? I don't see its value if it is only used on this place. I would say, just make these two regular fields in the ReorgEvent.
| ExtraData interface{} | ||
| } | ||
|
|
||
| type eventReorgRow struct { |
There was a problem hiding this comment.
I think the point of meddler is to not have struct conversion before saving it to the db, because he is the one that does that in the background. So, I would say we don't need this struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reorg_eventwith reorg detailsFixes #121