-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: added migration scripts #326
base: master
Are you sure you want to change the base?
Conversation
…ion tasks. Amended some attribute paths as required.
Look to add helper methods to https://github.com/adaptlearning/adapt-migrations/blob/master/api/helpers.js. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor point/new change, but working nicely, tested using v2 config/course and all mutating as expected.
migrations/v2.js
Outdated
let spoorConfig; | ||
const shouldStoreResponsesPath = '_tracking._shouldStoreResponses'; | ||
const scormVersionPath = '_advancedSettings._scormVersion'; | ||
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '<2.0.2' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '<2.0.2' }); | |
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '>=2.0.0 <2.0.2' }); |
migrations/v2.js
Outdated
updatePlugin('adapt-contrib-spoor - update to v2.0.2', { name: 'adapt-contrib-spoor', version: '2.0.2', framework: '>=2.0.0' }); | ||
}); | ||
|
||
describe('adapt-contrib-spoor - v2.0.0 to v2.0.5', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The majority of the describes/whereFromPlugin are from v2.0.0, to be consistent with others can we just update these to the version before the one we're upgrading to.
describe('adapt-contrib-spoor - v2.0.0 to v2.0.5', async () => { | |
describe('adapt-contrib-spoor - v2.0.4 to v2.0.5', async () => { |
…w agreed format, so a range is only included where appropriate.
Fixes #324.
New