Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: added migration scripts #326

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

New: added migration scripts #326

wants to merge 7 commits into from

Conversation

danielghost
Copy link
Contributor

Fixes #324.

New

  • Added migration scripts.

@danielghost
Copy link
Contributor Author

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor point/new change, but working nicely, tested using v2 config/course and all mutating as expected.

migrations/v2.js Outdated
let spoorConfig;
const shouldStoreResponsesPath = '_tracking._shouldStoreResponses';
const scormVersionPath = '_advancedSettings._scormVersion';
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '<2.0.2' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '<2.0.2' });
whereFromPlugin('adapt-contrib-spoor - from v2.0.0 to v2.0.2', { name: 'adapt-contrib-spoor', version: '>=2.0.0 <2.0.2' });

migrations/v2.js Outdated
updatePlugin('adapt-contrib-spoor - update to v2.0.2', { name: 'adapt-contrib-spoor', version: '2.0.2', framework: '>=2.0.0' });
});

describe('adapt-contrib-spoor - v2.0.0 to v2.0.5', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of the describes/whereFromPlugin are from v2.0.0, to be consistent with others can we just update these to the version before the one we're upgrading to.

Suggested change
describe('adapt-contrib-spoor - v2.0.0 to v2.0.5', async () => {
describe('adapt-contrib-spoor - v2.0.4 to v2.0.5', async () => {

…w agreed format, so a range is only included where appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

Add migration scripts
2 participants